Implement HMAC-256/DH-256 support.

Jax - April 14, 2008 - 16:33
Project:OpenID Provider
Component:Code
Category:feature request
Priority:normal
Assigned:Jax
Status:closed
Description

I'm willing to give this a go.

#1

Jax - April 28, 2008 - 10:50
Title:Implement HMAC-256 support.» Implement HMAC-256/DH-256 support.
Status:active» needs work

This patch uses the PHP5 only hash() and hash_hmac() functions. Now the provider can do DH-SHA1 and DH-SHA256 association. I need to investigate when the HMAC-SHA256 assoc_type is used.

You can now use openid_provider with the Zend_OpenID_Consumer which uses DH-SHA256 when talking to an OpenID 2.0 provider.

Anyone knows any openID client that can be used to test all the combinations?

AttachmentSize
openid_provider.patch 4.47 KB

#2

Jax - April 28, 2008 - 11:04

This should add hmac-256 support when there isn't a session_type set. It's not tested though. Some cleanup of the patch is needed as well.

AttachmentSize
openid_provider.patch 4.87 KB

#3

Jax - April 30, 2008 - 12:20
Status:needs work» needs review

Patch has been cleaned up.

AttachmentSize
openid_provider.patch 5.84 KB

#4

walkah - May 26, 2008 - 18:20
Status:needs review» fixed

committed. thanks, Jax!

#5

Anonymous (not verified) - June 9, 2008 - 18:23
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.