Drop Promoted items setting
Aron Novak - April 14, 2008 - 19:42
| Project: | FeedAPI |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
Drop that Promoted items settings. It's not FeedAPI's duty to take care what is and isn't promoted. It's assigned to 6.x, but need to do at 5.x too.
#1
Here's a patch for D6. It's not so complicated is it?
perhaps feedapi should expose triggers to do this kinds of messin' around? or would it be right to rely on existing triggers for nodes?
#2
#3
Updated patch. No functional changes.
Do we need an update function for this.
#4
Well, I have yet anoter patch which will the the behaviour as is + add a new secial value:
if promote is_numeric and promote < 0
then set all non promoted items for this feed to promoted.
To be honest, in my use case, I want to promote every items. Or at least leave them as set by my default story/page workflow settings.
I was surprised to see that the behaviour is:
if N > 0: amongst the last N, promote the ones that are not yet.
if N == 0: demote all promoted.
To me 0 would mean do nothing, leave as is.
I am new o this module so I might get it wrong.
Anyow, find attached a patch that will enable the value -1 (actually anything < 0) to promote every items from a feed which is not yet promoted.
#5
I think the vagaries of this feature and the limitations of "promote to front page" mean that this option should be completely removed.
Normal functioning of a site that depends on "promote to front page" allows all kinds of content types to have piles and piles of nodes that are promoted to front page. The front page is limited to 10 items (or whatever is set in the post settings admin screen). If there are more than 10 items, you get a pager.
If people need something more complicated than this, they should be using Views to control how the front page is constructed.