Incompatibility with Date API 5.2

alakon - April 14, 2008 - 23:29
Project:User Suspend
Version:5.x-1.2
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:won't fix
Description

Date module version 2.0, which introduces date_api version 5.2, adds a field "timezone_name" to the users table. Because the user_suspend_users table does not have this field, both suspend and unsuspend operations do not work after date_api 5.2 is installed.

#1

alakon - April 14, 2008 - 23:30
Status:active» needs review

See patch. Code could be improved -- but it works in the meantime as a fix for those with the problem.

AttachmentSize
user_suspend-update-for-date_api-5.2.patch 1.4 KB

#2

John Money - April 15, 2008 - 17:11

Thanks for patch. Will review this week and issue new release.

#3

John Money - June 30, 2008 - 06:20

Finally had a chance to look at the reported incompatibility with Date 2.0 RC. Thanks for the patch!

I've decided to copy over only the default fields to the user_suspend tables (e.g. gracefully degrade from a condition I had never expected). I think its not so good practice to accommodate every (any?) module that chooses to alter the default core Drupal tables, particularly node and users. What this means relative to the Date module is that a user that is suspended and then unsuspended will lose the timezone_name data.

As stated, the next release will gracefully degrade and remain operational with Date 2.0 RC. It will also present a warning when the schema for the core tables differs from what is expected by User Suspend.

#4

John Money - June 30, 2008 - 16:38
Version:5.x-1.1» 5.x-1.2
Status:needs review» won't fix

User Suspend 1.2 and Date 2.0 RC can now peacefully coexist.

 
 

Drupal is a registered trademark of Dries Buytaert.