Bibtex file import actually works, however, a blank page is returned instead of a confirmation page.

Comments

rjerome’s picture

Sounds like a PHP problem to me. Most likely you are running out of memory or the script is exceeding the maximum run time limit. If you have access to the php.ini file on your server, you should try increasing the memory limit first.

Ron.

dlx’s picture

I have 64M memory limit for php. Version 1.13 did not have this problem.

rjerome’s picture

Ok, That should be sufficient. Do you see any errors in the PHP logs? (Not the drupal logs, but the actual php log)

There was a change in the bibTex parser since 1.13, so I'll check to make sure everything is working as expected.

dlx’s picture

Hi Ron,

The php error is:

Cannot modify header information - headers already sent by (output started at ~/public_html/sites/all/modules/biblio/bibtexParse/PARSEENTRIES.php:617) in ~/public_html/includes/common.inc on line 314.

Alex.

soxofaan’s picture

Version: 5.x-1.15 » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new4.52 KB

The reason is that some include files from the bilbio module have whitespace after the closing "?>" tag.
This whitespace is emitted before the headers are sent, which is why you get the "headers already sent" error message.

The easiest fix is to omit the "?>" closing tag all together at the end of module and include files.
This is a feature of PHP (see the note on http://www.php.net/manual/en/language.basic-syntax.instruction-separatio...),
and common use in Drupal code (see http://drupal.org/node/545).

rjerome’s picture

Status: Needs review » Fixed

Your quite right, thanks for pointing that out.

Ron.

soxofaan’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
StatusFileSize
new2.94 KB

should be also fixed in DRUPAL-6--1 and HEAD probably

in attachment, patch for DRUPAL-6--1

rjerome’s picture

Status: Patch (to be ported) » Fixed

Already done...

Thanks,

Ron.

soxofaan’s picture

Status: Fixed » Active

yeah, sorry, I was too fast ;)

But I think you forgot bibtexParse/PARSEMONTH.php and bibtexParse/PARSEPAGE.php in both DRUPAL-5 and DRUPAL-6--1

And in HEAD there also seem to be some trailing "?>" in:
biblio_style_apa.inc
biblio_style_classic.inc
biblio_style_cse.inc
biblio_z3950.module
bibtex.php
endnote7_parser.inc
endnote8_parser.inc

rjerome’s picture

Status: Active » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.