Closed (fixed)
Project:
Drupal core
Version:
x.y.z
Component:
other
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Jun 2005 at 15:54 UTC
Updated:
10 Apr 2006 at 10:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
axel commentedSorry, previous patch broken (space was skiped). Next patch works ok. Also prefixing for DROP TABLE IF EXISTS statement added.
Comment #2
killes@www.drop.org commentedI've tested the patch and can say it works. Don't know if we need this feature, as neither statement is used by Drupal core.
Comment #3
Bèr Kessels commentedI would say: go for it. It works, and I already once had to hand-edit all my custom modules because this thing was not in the prefix.sh
This works as expected, and makes prefixing contributed sql files easier.
Comment #4
Cvbge commentedDROP TABLE IF EXISTS does not work with postgresql (it does not support IF EXISTS statement)
Comment #5
axel commentedPatch don't touch DROP TABLE IF EXISTS, it's already presents in the script. Anyway prefix.sh don't change any statements in SQL, just prefix tables. If IF EXISTS presented in SQL for Postgres then it is SQL-script problem, not prefix.sh.
Comment #6
webchickTested against privatemsg.mysql which has both of these statements and it works as advertised. Thanks!
Comment #7
webchickEr. I suppose I should've actually tested the patch rather than just copy/paste the lines I needed, eh? ;)
Here is a re-rolled version that applies against HEAD.
Comment #8
webchickAnd here's one for 4.6 as well.
Comment #9
webchickLet's try that again and pretend I don't have a crappy Windows text editor. :P
Sorry, I will quit spamming now. :P
Comment #10
gerhard killesreiter commentedapplied
Comment #11
(not verified) commented