Closed (fixed)
Project:
Event Repeat
Version:
5.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Apr 2008 at 00:51 UTC
Updated:
14 Jul 2012 at 19:23 UTC
Scenario: an event is meant to happen every second Saturday. When creating the event, the event repeat settings are as follows:
The first event in the sequence appears on the correct date. Each following repeated event is meant to occur every second Saturday, but instead appears, at the correct time, every second Friday.
We're running 5.7, all contrib modules are up to date, MySQL 5.0.51a, PHP5.2.5.. any insight would be greatly appreciated.
Comments
Comment #1
seanbfuller commentedThis may be an interface problem. Try setting the repeat type to weekly and see if that helps. Otherwise, what is your site time zone set to and what is the time for the event?
Comment #2
Adduc commentedI'm doing using a weekly interval, timezone -5:00 on Pretty fresh Drupal 5.7 installation. Trying to create a recurring event, the first day goes in successfully, but every occurrence following is placed a day prior to what the original was set at.
Upon editing any of the errored dates and saving, the days they occur is pushed one day prior to that, now making it two days off the supposed dates.
Comment #3
seanbfuller commentedAt what time are these events happening? (1:00, 12:00, 16:00, etc.)
Comment #4
Draggan commentedsame problem here.
eg.
WEEKLY BYDAY=TU,5TU
MONTHLY BYDAY=1TU
some or all repeating events appear one day too early. (i have more than 120 repeating events here)
interestingly you can't even edit the event to set the date one day later, you'll get
"You cannot edit an event start time to a day different than the one defined in the repeat pattern in this manner. This is not currently supported."
my workaround:
# delete all repeating events for june 08:
DELETE FROM `drupal`.`event` AS `event`,
`drupal`.`node` AS `node`,
`drupal`.`event_repeat_nodes` AS `event_repeat_nodes`
USING `drupal`.`event` AS `event`,
`drupal`.`node` AS `node`,
`drupal`.`event_repeat_nodes` AS `event_repeat_nodes`,
`drupal`.`event_repeat` AS `event_repeat`
WHERE `event`.`nid` = `node`.`nid`
AND `event`.`nid` = `event_repeat_nodes`.`nid`
AND `event_repeat`.`rid` = `event_repeat_nodes`.`rid`
AND `event`.`event_start` < 1214863200
AND `event`.`event_start` > 1212271200
# reset repeat_last_rendered to Jun 1 2008
update event_repeat set repeat_last_rendered="1212271200" where repeat_end > 1213833599;
and downgrade to eventrepeat 5.x-1.0.
Comment #5
Yappyfox commentedI am having the same issue, with weekly repeating events..
Here is what I have noted:
My site default time zone is -04:00
My personal TZ is the same.
If I create a weekly event for examples: Every tuesday, 6am - 9am, Events will show up on every tuesday just fine. If I try to create that same event for 6pm - 9pm, the first of the event will be correctly on tues, but every one afterwards will be listed on "Monday"
This seems to be some correlation in the timezoning of the event.
Comment #6
csc4 commentedI'm seeing the same - TZ GMT +1 (for BST), morning events (with 1.1) create ok and evening events create first one right and subsequent ones one day early.
Reverting to 1.0 allows both morning and afternoon events to be created correctly.
Comment #7
michael_kirk commentedSame problem here, however, reverting isn't a solution as the 5.x-1.0 version doesn't support "Every other week".
Comment #8
seanbfuller commented1.0 should support every other week. There wasn't any new functionality added there. Can you double check that?
It sounds like the 1.1 fix to make timezones work correctly (or another patch) is causing this. I'll try to take a look and see if I can find anything.
Comment #9
michael_kirk commentededit: I made a separate issue for this: http://drupal.org/node/269985
confirmed that "every other week" doesnt work with eventrepeat-1.0 using event-1.0
my steps:
I have my own cck type, "course-meeting".
In the admin/content/types/course-meeting
I have configured
Show in event calendar: Only in views for this type
and checked "Allow repeat events"
When I add this content type, I enter the start and finish dates.
september 5 2008-8:00
september 5 2008-11:15
Repeate type: weekly
end settings: december, 5 2008
advanced:
interval: 2
days: Friday
This only produces the original node, and none later in the sequence.
When I change interval to "1" it creates one every week (as it should).
can I give you any more information?
Comment #10
seanbfuller commentedOk, you might be right. I think there was a bug in that version. I thought you meant it wasn't an option. Either way, needs fixing.
Comment #11
ambereyes commentedI believe that I found the bug. It is does not seem to have anything to do with timezones, just using the wrong variable for the start date.
Line 1829 of eventrepeat in the _eventrepeat_render_nodes function.
should be
Katrina
--
www.ambereyes.net
Comment #12
Openlogic commentedKatrina -
I wasn't able to find the specific line of code (event_explode_date ...) you referenced in the _eventrepeat_render_nodes() function. We're running version 5.x-1.1 of eventrepeat.
Any help would be appreciated.
Thanks
Comment #13
ambereyes commentedYikes!
I am sorry, I am running 5.x-2.x-dev
sorry about that ...
Katrina
Comment #14
cfung commentedI can reproduce the problem mentioned in post #5. I'm using v1.1.
Any progress on a patch or bug fix? Many thanks!
Comment #15
seanbfuller commentedHas anyone been able to test the fix katrina posted above?
Comment #16
NewZeal commentedI tried it but found no such function (event_explode_date()) in 5.x-2.x-dev so it wasn't a go-er.
Comment #17
shashi_lo commentedI found the solution for it kicking back one day short for repeating events, but I'm not sure what it does. Some one will know and explain.
Change this near line 2171:
To this:
The $startday was being pushed a day short. Every other interval still doesn't work as well.
Comment #18
schwascore commentedThis fixed my weekly and daily repeat problems. After looking through the code, especially comments by rconstantine, it looks like the day offset when comparing local timezones to GMT is where the error begins. My uneducated guess is that this change makes it that there is no day offset, thereby nullifying the error.
Comment #19
seanbfuller commentedshashi_lo's fix in #17 for 5.x-1.x has been committed to that dev branch. CVS diff message is here:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/eventrepeat...
ambereyes's fix in #11 for 5.x-2.x has been committed to that dev branch. CVS diff message is here:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/eventrepeat...
If others who were having these problems could please pull down the appropriate dev branch and test, that would be greatly appreciated. Marking this as fixed. If you find a problem related to this, please reopen.
Comment #20
NewZeal commentedI applied shashi_lo's fix and it appears to work. No complaints. Thanks shashi_lo.
Comment #21
clymber commentedThe latest dev branch 1.x fixed the problem for me.
Comment #22
clymber commentedSorry, my goof. I accidentally altered the version of this bug.
Comment #23
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.