I noticed on the AddThis website that you can customize the button.
I believe it would be greatly beneficail if this was/could be added into the options of your module.

Cheers. Keep up the good work.

CommentFileSizeAuthor
#4 addthis-5.x-modified.tar_.gz2.26 KBvesapalmu
#2 addthis.module.patch8.18 KBvesapalmu

Comments

accessiveapps’s picture

accessiveapps commented
Assigned: Unassigned » accessiveapps

hey mediamunkey,

I ll take a look.

I will for sure make a admin settings page in the future where you can set up the button layout and of course integrate the RSS somehow.

Stay tuned and thank you for the feedback

Dee

vesapalmu’s picture

vesapalmu commented
Version: 5.x-1.0 » 5.x-1.2
Status: Active » Needs review
StatusFileSize
new addthis.module.patch8.18 KB

I needed to customize the button and widget so I created a quick hack to add admin interface to the module. I only tested the patch quickly and everything seems to work, but please test it yourself before using it and feel free to improve it.

vesapalmu’s picture

vesapalmu commented

I forgot to put hook_perm to enable admin to other than uid 1. Patch still needs some loving anyway, so just forget it for now.

vesapalmu’s picture

vesapalmu commented
StatusFileSize
new addthis-5.x-modified.tar_.gz2.26 KB

I needed this for a client so I actually rewrote most of the module. There are a few major changes:

1) Username is no longer fixed and can be changed trough administration.
2) There is now administration section for full control over how the button is displayed.
3) Module now implements hook_block to create a block for the button. Visibility of this block can be controlled as usual so the button can be limited by content type, taxonomy or what ever you want.
4) Module also implements hook_nodeapi and AddThis button can be used in a theme with: print $node->content['addthis']['#value'];
5) There are now two permissions for the module: one for viewing the button and one for administration.

I didn't create a patch since this is really a rewrite. New unofficial version of the module is included for review.

MediaMunkey’s picture

MediaMunkey commented

Thanks for the new code wesku. It seems really great.
I noticed that it no longer adds the button into node links though. I couldn't find an option to turn it on so I assume you took it out.
It just so happens that that is where I place the button on my site so it would be with great appreciation if you could slip that option back into the module.

vesapalmu’s picture

vesapalmu commented

You are right about that it would be easier for many folks to have it as option. I'll put it back in and add admin checkbox for it. There were also some nice improvements in a patch by user stevek@virtustate.com and I'll try to integrate some concepts he had. I had a chat with degree and I will start co-maintaining the module with him from now on.

vesapalmu’s picture

vesapalmu commented
Status: Needs review » Fixed

There is now a new beta release of the module. It still needs some review and work before it can be recommended for production environments. Any feedback on new functionality is welcome.

MediaMunkey’s picture

MediaMunkey commented

Great to see the rewrite is up and going. I would love to try it out but I am using Drupal 5.7.
Would you consider creating a fork compatible with 5?

Hmm, just a quick edit here.
I had a quick look at the code and it looks like you mistakenly added the old code.
At the moment it's no more than the old 1.2 version for Drupal 6.

vesapalmu’s picture

vesapalmu commented

Uh, thanks for noticing this. CVS had correct version, but I had tagged the wrong version for the release. I just fixed this with a new release. New release will replace the old as soon as it gets published. It's been many years since I last used old CVS outside drupal.org...

I'll do a port to D5 after everything is ok with D6.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.