Pre-existing users will not be logged in by webserver_auth
barry_johnson - April 17, 2008 - 17:13
| Project: | Webserver authentication |
| Version: | 5.x-0.0-rc1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Jump to:
Description
If a user is created by normal drupal methods, then tries to login via webserver authentication, the user won't be logged in. This patch changes the user_external_load to a user_load call to take care of this.
| Attachment | Size |
|---|---|
| webserver_auth.module.preexisting_users_not_logged_in.patch | 712 bytes |
#1
user_external_load() makes our mapping more robust. a user can change his drupal username and still get logged in properly. perhaps we should just forget about that feature. comments?
#2
I think that is a nice feature to have. It just bit me because I was adding your auth module after we already had several people using the site. Their webserver userid was the same as their drupal userid and it wouldn't work for them the other way. I think mine is a special case and not really the norm. Perhaps we could make it a an admin panel checkbox? Something like "[] allow pre-existing drupal users to authenticate with webserver auth?"
Just thinking out loud..
B.
#3
not too fond of that checkbox.
#4
I was having some issues like this, namely when an account was created before I turned on the auth module. This fixes the SQL error that comes up:
http://drupal.org/node/284515