Port to 6.x - Functional for the most part

mfer - April 18, 2008 - 01:46
Project:Yahoo Terms
Version:6.x-2.1
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

How about a port to drupal 6?

#1

designerbrent - April 20, 2008 - 14:26
Status:active» needs work

Here is a first pass at this using mainly coder module to get the big changes. There are still several errors being thrown.

AttachmentSize
yahoo_term_d6-firstpass.diff 5.97 KB

#2

designerbrent - April 21, 2008 - 00:36
Title:Port to 6.x» Port to 6.x - Functional for the most part
Status:needs work» needs review

Ok, here is another pass at this. It seems to be working correctly now with only one function fully commented out. I'm having problems with the function yahoo_terms_link() throwing a mySQL error. If anyone wants to take a look at it, please feel free to take a hack at it. The problem that I have is that I'm not sure exactly what the function is looking for so I just removed it for now.

AttachmentSize
yahooterms.patch 8.84 KB

#3

designerbrent - April 21, 2008 - 13:00

Little more cleanup and add a hopeful fix for #156853: Fatal error: Unsupported operand types

This is a full patch against the 5.x-1.x-dev version.

AttachmentSize
yahooterms6.patch 8.84 KB

#4

alliax - August 1, 2008 - 04:15

Please keep me updated on this, I really want some sort of automatic tagging for my nodes, do you know of another module? Or why yahoo terms is not yet ported to 6, it looked promising...

Cheers,
James

#5

Shiny - August 6, 2008 - 04:29

I've rerolled this patch -- it's now a diff against end of DRUPAL-5 branch (instead of the tarball).
I've also cleaned up so code-style.pl is happy it matches drupal code style standards

tested on Drupal6.3, postgresql (both 7.4 and 8.something), apache2, php5.

AttachmentSize
yahooterms6.patch 9.7 KB

#6

alliax - August 6, 2008 - 16:10

Then please user Aron Novak, could you release a 6 version of the module? Thank you. It doesn't matter if there are some bugs/issues with the patch (which I don't know how to use, I much prefer a 6 version) because the bugs will be reported, but many more users will test the module if there's a 6 branch, because only 0.01% of users will apply a patch and put it on their site.
We're mostly waiting for a first 6 branch release.

Cheers,
James

#7

TallDavid - November 19, 2008 - 17:04

Please release a 6 version of the module.

#8

Shiny - November 21, 2008 - 03:19

@TallDavid / @alliax please test the patch and report back.

#9

alliax - November 21, 2008 - 04:05

Patching a module is not something that many people know how to do (like me) or really care to learn to do. So if you really want people to report bugs to you it's easy: release a drupal 6 version, even a dev version and then wait until people will install it and then come back to cry and report issues.

It's the wise thing to do because waiting for people with the know-how of applying patches means a lot less manpower !

#10

Shiny - November 21, 2008 - 07:45

@Alliax patching isn't rocket science. There's a howto on http://drupal.org/patch/apply

#11

alliax - November 21, 2008 - 16:30

I don't know if you got my pôint, I didn't say it is difficult I said if you want bug reports from most drupal users, release at least a dev version.

#12

TallDavid - November 22, 2008 - 17:29

Alliax,
I concur. There needs to be a 6.x-x.x-dev version to facilitate testing.

#13

kaw3939 - November 23, 2008 - 00:53

I have a version 6 module working for the most part, but it isn't a upgrade of this one, it is a rewrite because I didn't know about this one. We started to make another module that did something similar to this, but then decided to separate this functionality from the other module. The other thing that we did was check for duplicate tags inside a vocabulary, rather than checking before the tags are added. This may be more expensive to do but it might be more flexible. You may be doing this on your module too, but I just skimmed through your code.

Would anyone want to look at our version 6?

we just have a couple last fixes / testing to do to make sure that our module is fit for human consumption as a developmental release.

Our module is also going to use calais, but differently than the current Calais module.

We are adding a couple features, you have in yours and some that we need for ours, so these will be similar but not the same.

#14

Shiny - November 25, 2008 - 09:07

i've branched a DRUPAL-6-1 in cvs - should appear on this project page for download soon.

#15

Shiny - November 25, 2008 - 09:07
Status:needs review» reviewed & tested by the community

#16

Shiny - November 25, 2008 - 09:08
Version:5.x-1.x-dev» 6.x-6.x-dev
Assigned to:Anonymous» Shiny

#17

TallDavid - March 21, 2009 - 21:46
Version:6.x-6.x-dev» 6.x-2.1
Assigned to:Shiny» Anonymous
Status:reviewed & tested by the community» closed

Version 6.x-2.1 was released on 2008-Nov-25. Closing the ticket since a production release now exists.

 
 

Drupal is a registered trademark of Dries Buytaert.