I've just installed this module on Drupal 5.7 on XAMPP for Windows. (It looks like a REALLY cool module btw.)

When I do a hooks update, I get message from Drupal:

* The selected file D:\xampp\tmp\fil1D.tmp could not be uploaded, because the destination is not properly configured.
* The selected file D:\xampp\tmp\fil1E.tmp could not be uploaded, because the destination is not properly configured.
* The selected file D:\xampp\tmp\fil1F.tmp could not be uploaded, because the destination is not properly configured.

However, below that I get these messages:

* Hook documentation has been updated.
* The configuration options have been saved.

The status text says:
Your last hook documentation update was Fri, 04/18/2008 - 10:50.

And there's nothing in the /files folder.

So to summarize:
- it doesn't work :)
- the module seems to think it does

Creating the /files/hooks folder myself solves the problem.

A suitable fix for this bug would be to add a line to the installation instructions, eg:
1b. Create a folder 'hooks' inside the folder 'files'.

Comments

joachim’s picture

joachim commented

If anyone knows enough about file.inc to look at this, the first problem is that file_create_path() is returning FALSE.

joachim’s picture

joachim commented
Status: Active » Fixed

Several things combine to cause this problem:

- file_create_path () returns the wrong thing if /files hasn't been created. bug in core: http://drupal.org/node/36713. Added some workarounds for now because I can't be bothered to visit the status page on fresh installs.
- module_builder_update_documentation returns FALSE if there's a problem, but the call to that does nothing with the returned value and then goes on to say 'Hook documentation has been updated.' no matter what. Um, no.

A few other related fixes:
- check the directory exists BEFORE downloading all the stuff!
- set an error message if unable to connect. (you know, like if the intertubes are down)
- don't download the hook docs on first visit to the module builder building page. IMO it's rude to go downloading a heap of stuff without asking the user's permission.

All fixed in CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.