Please apply attached patch to current HEAD. By adhering to Drupal Coding Standards, you will gain a larger user-base and more actively contributing developers for this module.

Note: Attached patch does not alter the functionality, just the coding-style and PHPdoc/comments.

CommentFileSizeAuthor
#2 fierce_sso-HEAD.patch15.41 KBsun
#1 fierce_sso-HEAD.patch14.99 KBsun
fierce_sso-HEAD.patch14.68 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new fierce_sso-HEAD.patch14.99 KB

Further clean-up (patchs contains code changes now):

- Removed needless user help text for the path user/help.
- Fixed path for admin/build/modules.
- Changed module description in help text for admin/modules.
- Removed unnecessary menu item titles for menu callbacks.
- Fixed menu item title for fierce_sso settings.
- Replaced multiple occurrences of sizeof() with empty().
- Improved logic in _fierce_sso_get_login_html().

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new fierce_sso-HEAD.patch15.41 KB

Last patch. Fixes the FIXME in fierce_sso_user() by implementing hook_exit() and appending the sso=logout query string to the redirection URL.

eli’s picture

eli commented
Status: Needs review » Reviewed & tested by the community

Thanks for the help, sun. This looks good. I'll upload it later today.

eli’s picture

eli commented
Status: Reviewed & tested by the community » Closed (fixed)
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Closed (fixed) » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.