Posted by tomaszx on April 18, 2008 at 10:02pm
Jump to:
| Project: | Translatable Comments |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | davidtrainer |
| Status: | closed (fixed) |
Issue Summary
This could be cool.
| Project: | Translatable Comments |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | davidtrainer |
| Status: | closed (fixed) |
This could be cool.
Comments
#1
If we can select specific languages to be available for translation, that would make it a better tool.
In any case, does anyone know how to remove / add some of the languages in the code?
#2
#3
This change has been committed to HEAD and is available in the current dev release.
#4
I tested the new code and it works. Here are some observations:
- Still doesn't show in IE 6.0 and above.
- In FireFox, it only displays the 2-character country codes hence a pop-up with the actual country name would be useful. e.g.: iw is supposed to be Hebrew, hy Armenian and el Greek. How can anyone know these codes...;)
- Some of the codes don't work, e.g.: Armenian (hy) says
could not reliably detect source language- on /admin/settings/translatablecomments, where is the language list coming from? can we add/remove any of them?
- above the country codes can we have a text (in small characters) saying Translate to...
Great module, thanks!
#5
@Vako,
I wasn't aware that we had a problem except for IE8, but I just did some testing and it's not appearing in any of them. I've just opened #638550: IE Compatibility and marked it critical.
I agree. Please create an issue for this. There should at least be an option on the admin page for choosing which to display.
This is actually a limitation of the translate API - the module is just reporting the error that it received from Google.
Those languages come from Google's class reference for the language API. It's not dynamically updated or anything, so if Google enables a new language and someone needs to use it, they will have to create an issue for this. The admin page is only seen by admins so I'm not sure why we would want to remove any of the languages.
You should handle this in your theme. My intention is to keep the markup and appearance of the buttons as minimal as possible, so it will be as extensible as possible for theme developers. That's also the motivation for #638516: Load css externally.
Thanks for the feedback and I'm glad you are finding this module useful.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.