Any info to port for D6?

mrgoltra - April 19, 2008 - 03:27
Project:Share
Version:5.x-2.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:needs review
Description

Good Day,

I was wondering if this module will be ported to D6?

Thanks,

Mark

#1

Fayna - May 31, 2008 - 04:11

Subscribing as I prefer this module to the other share modules. :-)

#2

Deciphered - June 9, 2008 - 09:52
Status:active» needs review

Initial patch to port Share to Drupal 6.

AttachmentSize
share-248511-6.x-port-1.patch 23.89 KB

#3

Fayna - June 9, 2008 - 20:01

I tried patching this with the latest dev version of Share and got these errors:

patching file share.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file share.info.rej
patching file share.install
Hunk #1 succeeded at 1 with fuzz 2.
patching file share.module
Hunk #1 succeeded at 2 with fuzz 1.
Hunk #5 succeeded at 163 with fuzz 2.
Hunk #8 succeeded at 350 with fuzz 1 (offset 6 lines).
Hunk #9 succeeded at 365 (offset 6 lines).
Hunk #10 succeeded at 423 (offset 6 lines).
Hunk #11 succeeded at 436 (offset 6 lines).
Hunk #12 succeeded at 450 (offset 8 lines).
Hunk #13 succeeded at 458 (offset 8 lines).
Hunk #14 FAILED at 471.
Hunk #15 FAILED at 506.
Hunk #16 succeeded at 576 (offset 8 lines).
Hunk #17 succeeded at 633 (offset 8 lines).
Hunk #18 succeeded at 654 (offset 8 lines).
Hunk #19 succeeded at 665 (offset 8 lines).
Hunk #20 succeeded at 675 (offset 8 lines).
Hunk #21 succeeded at 711 (offset 8 lines).
Hunk #22 succeeded at 730 (offset 8 lines).
2 out of 22 hunks FAILED -- saving rejects to file share.module.rej

Should I try the alpha instead?

#4

Deciphered - June 9, 2008 - 22:21

Patch against HEAD.
If you don't have CVS setup, then you can download each file via the Web CVS Client: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/share/?path...

Edit: There will be a slight issue as when I downloaded HEAD via CVS I only downloaded the main directory, not the sub-folders. I will re-roll the patch against the dev version later on.

#5

Deciphered - June 9, 2008 - 22:58

New patch, this one is for 5.x-2.x-dev.

Tested a bit and can confirm that ShareThis works, not sure about the standard Share mode though.

AttachmentSize
share-248511-6.x-port-2.patch 24.3 KB

#6

Deciphered - June 10, 2008 - 07:23

Updated patch:
- Fixes for 'Share' mode

#7

Deciphered - June 10, 2008 - 07:23

Heres the file for above.

AttachmentSize
share-248511-6.x-port-3.patch 25.93 KB

#8

Fayna - June 25, 2008 - 01:26

Patched fine and I was able to install the module great. However, when I chose some settings and enabled the "Share" links on some node types, I hit "Save" and the page went blank. I looked in my log to find this:

[24-Jun-2008 21:22:43] PHP Fatal error:  Call to undefined function  _service_links_show() in /Applications/MAMP/htdocs/drupal6test/sites/all/modules/share/share.module on line 288

#9

Deciphered - July 1, 2008 - 04:14

My guess is you haven't got Service Links installed, or you're using an incompatible version.
If that's the case then maybe there should be some more error detection to stop this issue.

#10

scottrigby - August 17, 2008 - 15:12

This patch no longer works with HEAD :(

any chance of an update?

:) Scott

#11

Psicomante - August 22, 2008 - 21:32

subs

#12

Psicomante - August 22, 2008 - 21:32

subs

#13

scott859 - January 3, 2009 - 06:51

subscribing.

#14

darumaki - February 9, 2009 - 20:09

+

#15

darumaki - February 9, 2009 - 20:10

What other share modules ? I wasn't aware any existed.

 
 

Drupal is a registered trademark of Dries Buytaert.