Good Day,

I was wondering if this module will be ported to D6?

Thanks,

Mark

Comments

Fayna’s picture

Subscribing as I prefer this module to the other share modules. :-)

deciphered’s picture

Status: Active » Needs review
StatusFileSize
new23.89 KB

Initial patch to port Share to Drupal 6.

Fayna’s picture

I tried patching this with the latest dev version of Share and got these errors:

patching file share.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file share.info.rej
patching file share.install
Hunk #1 succeeded at 1 with fuzz 2.
patching file share.module
Hunk #1 succeeded at 2 with fuzz 1.
Hunk #5 succeeded at 163 with fuzz 2.
Hunk #8 succeeded at 350 with fuzz 1 (offset 6 lines).
Hunk #9 succeeded at 365 (offset 6 lines).
Hunk #10 succeeded at 423 (offset 6 lines).
Hunk #11 succeeded at 436 (offset 6 lines).
Hunk #12 succeeded at 450 (offset 8 lines).
Hunk #13 succeeded at 458 (offset 8 lines).
Hunk #14 FAILED at 471.
Hunk #15 FAILED at 506.
Hunk #16 succeeded at 576 (offset 8 lines).
Hunk #17 succeeded at 633 (offset 8 lines).
Hunk #18 succeeded at 654 (offset 8 lines).
Hunk #19 succeeded at 665 (offset 8 lines).
Hunk #20 succeeded at 675 (offset 8 lines).
Hunk #21 succeeded at 711 (offset 8 lines).
Hunk #22 succeeded at 730 (offset 8 lines).
2 out of 22 hunks FAILED -- saving rejects to file share.module.rej

Should I try the alpha instead?

deciphered’s picture

Patch against HEAD.
If you don't have CVS setup, then you can download each file via the Web CVS Client: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/share/?path...

Edit: There will be a slight issue as when I downloaded HEAD via CVS I only downloaded the main directory, not the sub-folders. I will re-roll the patch against the dev version later on.

deciphered’s picture

StatusFileSize
new24.3 KB

New patch, this one is for 5.x-2.x-dev.

Tested a bit and can confirm that ShareThis works, not sure about the standard Share mode though.

deciphered’s picture

Updated patch:
- Fixes for 'Share' mode

deciphered’s picture

StatusFileSize
new25.93 KB

Heres the file for above.

Fayna’s picture

Patched fine and I was able to install the module great. However, when I chose some settings and enabled the "Share" links on some node types, I hit "Save" and the page went blank. I looked in my log to find this:

[24-Jun-2008 21:22:43] PHP Fatal error:  Call to undefined function  _service_links_show() in /Applications/MAMP/htdocs/drupal6test/sites/all/modules/share/share.module on line 288
deciphered’s picture

My guess is you haven't got Service Links installed, or you're using an incompatible version.
If that's the case then maybe there should be some more error detection to stop this issue.

scottrigby’s picture

This patch no longer works with HEAD :(

any chance of an update?

:) Scott

psicomante’s picture

subs

psicomante’s picture

subs

scott859’s picture

subscribing.

darumaki’s picture

+

darumaki’s picture

What other share modules ? I wasn't aware any existed.

greenskin’s picture

Status: Needs review » Closed (fixed)