I've made the usage of the t() function more consistent across all strings and caught a couple of strings which were not translateable.

CommentFileSizeAuthor
image.module_missed_translation_strings.patch2.19 KBbaudolino

Comments

Robrecht Jacques’s picture

Robrecht Jacques commented

format_plural strings don't have to be called with t(...). The format_plural functions takes care of that, as noted in the docs of format_plural.

As for the other two lines you've changed: i don't think that changing double quotes to single quotes changes anything. If it does I seem to know less about PHP that I thought.

Just to let you know that these are not bugs.

Kr,
Robrecht

baudolino’s picture

baudolino commented

I never claimed that I submitted a bug report - I just had to choose something from the list, and bug report was the closest thing. I just said I changed those for consistency. Call me obsessive-compulsive, if you like :) Which is also the case with using %count for the singular form (i.e. There is %count image - what's the point of using a variable name when the singular form is 1?). I have not seen this formulation in any other parts of Drupal, and I took the liberty of changing that as well).

If there were a lower level than minor, like uberminor :), rest assured I would've selected that priority level.

Robrecht Jacques’s picture

Robrecht Jacques commented

OK, I see now that "1 gallery" is more consistant than "%count gallery" although it is not really needed. Fixed it anyway :-)

BTW, using the t(...) when calling format_plural would actually introduce a minor bug so I haven't applied that. format_plural takes care of translating the strings.

Thanks,
Robrecht

mariagwyn’s picture

mariagwyn commented

I just updated to this patch, and it seems to have killed my image gallery. It shows up as an empty page. See topic: http://drupal.org/node/25559.

I went back to version 1.146.2.7 and it seems fine. I have no idea what the problem is, but I thought you should know.

Maria

Robrecht Jacques’s picture

Robrecht Jacques commented

It has nothing to do with this patch. The difference between v1.146.2.7 and v1.156 is described in http://drupal.org/node/24852. Briefly: you can't mix CVS version of image with non-CVS version of drupal (eg 4.6.0).

celticess’s picture

celticess commented

hmm I'm using a non cvs drupal(4.6.1) and CVS image module. Things show up just fine. Only image related issue I have is img_assist module not showing thumbnails(though it otherwise works).

Robrecht Jacques’s picture

Robrecht Jacques commented

Really?

I just did the test: I made a clean install of drupal-4.6.1. Then checked out the latest CVS version (HEAD) of image.module. Going to "admin/image" gives me an empty page. This is the expected behaviour.

Replaced the HEAD-version of contributions/modules/image with the DRUPAL-4-6 branch of it, reload the "admin/image" page and the page appears like it should.

So I repeat: if you not use the CVS-HEAD version of drupal, the latest CVS-HEAD version of image.module will not work.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)