Hi,

The yes_no widget doesn't work at all.
Please fix it. Or, scrap it (I don't think anybody is using it just yet!)

All of the other widgets seem to work fine.

Bye,

Merc.

Comments

sikjoy’s picture

Assigned: Unassigned » sikjoy
gorillapictures’s picture

i am using it....isn't working...

fluxline’s picture

how are you using it if it isn't working? just askin ...

mercmobily’s picture

Hi,

It would be great to fix this. sicjoy, is this within your reach?

Merc.

cedricfontaine’s picture

StatusFileSize
new9.46 KB

Seems to be related to CSS. This patch should fixed it

mercmobily’s picture

Hi,

A few notes about this patch:

1) I think you added loads of CR (carriage returns). Please watch out! Also, are you maintaining the same spacing?

2) Please make .diff files relative to the module's directory. In your case, the "patch" command looked for " modules/extra_voting_forms/widgets/yes_no/extra_voting_forms_all.css" -- however, you should create the patch while in "modules/extra_voting_forms", so that the patch command only uses the path " widgets/yes_no/extra_voting_forms_all.css" .

3) The patch fails! I am not sure why, but I can't apply this to CVS.

[root@sys113 yes_no]# patch --dry-run < ~/yes_no.patch 
(Stripping trailing CRs from patch.)
patching file extra_voting_forms_all.css
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file extra_voting_forms_all.css.rej
[root@sys113 yes_no]$

Please let me know :-D

Bye!

Merc.

Leeteq’s picture

Subscribing.

cedricfontaine’s picture

StatusFileSize
new9.22 KB

Please confirm with this one

mercmobily’s picture

StatusFileSize
new4.66 KB
new2.79 KB

Hi,

The patch still won't apply. Which command have you run?

I created a file called "test.css", where I put what I *thought* your patch should do. In fact, looking at your patch, it seems to delete pretty much everything and add everything from scratch, but starting from the wrong line number (?).

Then I ran " diff -up widgets/yes_no/extra_voting_forms_all.css widgets/yes_no/test.css > /tmp/test.patch".

The result is in attach. You will see test.css (which is what I *think* you wanted to do, please confirm) and test.patch.

I think it would be good to figure out why you were generating patches that wouldn't apply...!

Bye,

Merc.

cedricfontaine’s picture

Your test.css seems ok except the last line with a + sign at the beginning.

I don't know why but I have carriage returns problem with my working file, which breaks diff.

Also, I think we should remove widgets/yes_no/extra_voting_forms_js.css as it's not used.

mercmobily’s picture

Status: Active » Fixed

Hi,

OK, all good :-D
Big finally closedddddddddddddd!!!

** Thank you Cedric**

Merc.

mercmobily’s picture

Status: Fixed » Closed (fixed)