Flat out $node in phptemplate_node vars

i am gonna +1 this, as it simplifies the available variables.

I Add my +1 to the 'heap' too. But a slight additional feature:
Maybe we should then omit teh $node completely. It makes not much sense IMO to use the overheard of parsing along a rather often-used, and big varible, when its availabe in another form already
Maybe you should do some checking for already existing variables. One nevver really knows w

Ber

+1 to the flat, -1 to removing $node. I use various functions within my templates that require a $node object to be passed to them.

Committed to HEAD.

This patch causes a small bug with $picture. There exists a $node->picture (the relative URL to the submitter's picture) and a variables['picture'] (whether or not to show avatars within a template). chx kindly ensures that the $variables array always overrides anything in $node with $variables = array_merge(object2array($node), $variables);. But, this doesn't work if the template avatars have been set to OFF/Disabled/NULL in the template settings. Since it's set to off, the $node->picture gets seeded and the templates, checking on the existence of $picture, now spit out the relative URL to the picture. The attached patch turns renames $variable['picture'] to $variable['show_picture'].

This shoudn't be an issue with comment pictures, because $comment is not flattened.

Somehow, I forgot bluemarine.

To me it makes more sense to merge $show_picture and $picture. If we have a picture to show, set $picture. If we don't have a picture to show, make sure $picture is NULL. One variable is better than one, and gets the job done IMO.

I agree one variable is better than two.

This issue appears to be fixed by the existence of the 'toggle_node_user_picture' variable in PHPTemplate. Closing.