template-subtheme.php includes a query which updates the system table, but doesn't take into account the fact that a module using the same name as the subtheme also as an entry in the system table with the same name. When executed, this query causes my module to be turned off.

The attached patch simply adds to the WHERE clause causing it to update only where type = 'theme'.

CommentFileSizeAuthor
zen_subtheme_query.patch936 bytesmatt@antinomia

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Priority: Minor » Normal
Status: Needs review » Fixed

Okay, 2 points, Matt…

  1. You should never, never have a theme and a module share the same name. :-( Use footheme and foo.module to keep the namespaces separate.
  2. Yes, this is a bug. Good catch! :-)

Committed to DRUPAL-5--1. I’ll probably release a Zen 5.x-1.1 in the next couple days, but the patched -dev version should show up in the next 12 hours.

matt@antinomia’s picture

matt@antinomia commented

Thanks for the tip John. Can you be more specific about the hazards of using a module and theme with the same name? I've been doing it for quite some time now and have never had a problem until now (namespace collision or otherwise). In this case, I've written both the module and theme so I can guard against collisions. Do you think it's still important to use a different namespace?

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.