Will this be ported to 6.x anytime soon? On trying it out, I get a message from the core saying its incompatible.

CommentFileSizeAuthor
#16 249067.patch3.95 KBBevan
#11 firebug-6-x.patch2.23 KBtnanek
#4 firebug-6-x.patch2.23 KBtnanek

Comments

Anonymous’s picture

Anonymous (not verified) commented

Modules for 5.x are not compatible with 6.x.

http://groups.drupal.org/node/5036 - this link might be of help, if firebug isnt on there, either the maintainer hasn't updated the page, or perhaps isn't planning to port.

theemstra’s picture

theemstra commented

I would like it too!

tnanek’s picture

tnanek commented
Assigned: Unassigned » tnanek

I'm working on a patch for this right now, should be up by the end of the day.

tnanek’s picture

tnanek commented
Status: Active » Needs review
StatusFileSize
new firebug-6-x.patch2.23 KB

Attached is a patch.

I tried to make it fit coding standards as best I could while updating it to work with a 6.x Drupal install.

theemstra’s picture

theemstra commented

How is it going with the release?

tnanek’s picture

tnanek commented

I've done all I can - I made a patch and no one has tested it so it can't logically progress (I believe I made a few mistakes, but its been awhile since I tried it).

I can not make edits to the actual one since I am not the maintainer. All I can do is make patches for the maintainer to consider incorporating.

Anonymous’s picture

Anonymous (not verified) commented

sorry. didnt see this.

ninja, would like to co-maintain and commit your own patch?

Anonymous’s picture

Anonymous (not verified) commented

1 small thing,

$Id$
should be

$Id: $

that is all.

tnanek’s picture

tnanek commented

Sure, I would like to co-maintain - I will update the patch with the corrections this evening after a social event I have - meanwhile I don't yet have CVS access, so I'm going to be applying for that as soon as I could find the application for it... I'll have time to look for it this evening as well.

Anonymous’s picture

Anonymous (not verified) commented

cool.

i have some other modules that could use a co-maintainer lol :)

http://drupal.org/cvs-application/requirements

tnanek’s picture

tnanek commented
StatusFileSize
new firebug-6-x.patch2.23 KB

Here is the modified patch - I did not run this, and I only changed what needed to be changed in the code for the patch, I did not bother to make a patch again seeing as that would take more time and now I need to sleep - I have finals this coming week to study for as well, so more extensive work on the patch shall be pending for next weekend I believe.

I also submitted my CVS request.

AjK’s picture

AjK commented

Ninja Overlord CVS account app approved.

tnanek’s picture

tnanek commented

So - now you'll just have to wait for me to install CVS and get that to work - last time I tried it, it was a chore on its own (using SourceForge) so I think I'll need some time with that - give it until Friday, then chances are you'll be seeing a new release for 6.x

theemstra’s picture

theemstra commented

Yesterday?

Today i don't see anything too...

tnanek’s picture

tnanek commented

I'm sorry, personal issues came up to delay me from this for some additional time, now I'm trying to figure out the back-end things - a dev release of 6.x should be up by tomorrow evening.

[EDIT]
Apologies, it seems finding a CVS client for a mac is more difficult than I thought, and now I am having trouble setting it up.

Here's a separate forum post I made detailing my problems if you're interested. Long and the short of it - it is coming, thats as specific as I can be at this point.

Bevan’s picture

Bevan commented
StatusFileSize
new 249067.patch3.95 KB

Patch applies to DRUPAL-5;
* Fixes fatal php error due to extra closing curly bracket in previous patches.
* Updates hook_menu for Drupal 6.
* Implements hook_init for some hook_menu code that needs to be executed every request.
* Fixes bug casuing firebug control to not display in IE7 (missing slash / in closing a tag; <a> instead of </a>)
* Simplifies jquery
* Cleans up some whitespace issues.
* Adds firebug to the "Development" package
* Fixes CVS $Id$ tags

Anonymous’s picture

Anonymous (not verified) commented

Bevan, nice patch. looks perfect to me.

didn't get to test though.

Ninja Overlord, are you unable to figure out your setup?

Bevan’s picture

Bevan commented

This patch would be good for a 6--1-0 release, however we are using quite an old version of firebug. I created #351967: Update and simplify yesterday and rewrote firebug with the latest version of firebug lite, which has a whole new set of features. I think efforts for a Drupal 6 release should be focussed on releasing this as a 6--2-0 release.

tnanek’s picture

tnanek commented

I'm still trying to figure out how to use CVS correctly without overwriting things - I've only used Subversion on Sourceforge about a year ago, and am unsure how similar CVS is to that - I should find some time this week to give it a more dedicated shot. In addition, at the time when I used Subversion I was on a Windows computer, now I am on a Mac, so software is more difficult to find - especially updated software to work on an Intel based Mac.

As for the patches, I looked over the first one, have yet to try it out, but it looks good - I haven't had a chance to look at the one linked in #18 yet though - I figure CVS is a little more important for me to be understanding at this point in relation to this module.

kenorb’s picture

kenorb commented

any zip dumps?

theemstra’s picture

theemstra commented

Read the documentation!

markus_petrux’s picture

markus_petrux commented

Port to D6 doesn't seem to be committed, I wonder if you still need co-maintainer for this.

develcuy’s picture

develcuy commented

I'm maintainer of this module now, please help with #433444: Duplicated module? in order to decide the best solution for merging both modules.

Blessings!

develcuy’s picture

develcuy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.