Download & Extend

List of redirects url is not html safe

Project:Path redirect
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:sinasalek
Status:closed (fixed)

Issue Summary

List of redirects url is not html safe, so things like &lang do not show correctly.

AttachmentSizeStatusTest resultOperations
urls_list_html_safe.patch707 bytesIgnored: Check issue status.NoneNone

Comments

#1

Status:active» reviewed & tested by the community

Good catch. I think it makes sense to have both of those lines there be htmlspecialchars instead of check_url, since we're not presenting this as a clickable link: it's just text in the page. I've tested both versions, and they both seem fine.

AttachmentSizeStatusTest resultOperations
path_redirect-5.x-1.x_html_1.patch698 bytesIgnored: Check issue status.NoneNone

#2

Things are never as simple as they seem. The table displayed on the node edit page needs the same fix. Is the HTML Validator extension out for Firefox 3 yet?

AttachmentSizeStatusTest resultOperations
path_redirect-5.x-1.x_html_2.patch1.34 KBIgnored: Check issue status.NoneNone

#3

Status:reviewed & tested by the community» fixed

Went ahead and committed #2.

#4

I don't think so, firebug also is not available for firefox3 yet unfortunately.
Thanks for applying the patch

#5

It's rather buried in the release notes, but Firebug 1.1b is compatible with Firefox 3. I've been using it for a few weeks now, and it's working fine.

#6

Thanks HorsePunchKid i didn't know that :). and looks like firefox addon site is pretty much out of the date. HTML Validator for firefox 3 beta 5: http://users.skynet.be/mgueury/mozilla/download.html

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here