List of redirects url is not html safe, so things like &lang do not show correctly.

CommentFileSizeAuthor
#2 path_redirect-5.x-1.x_html_2.patch1.34 KBHorsePunchKid
#1 path_redirect-5.x-1.x_html_1.patch698 bytesHorsePunchKid
urls_list_html_safe.patch707 bytessinasalek

Comments

HorsePunchKid’s picture

HorsePunchKid commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new path_redirect-5.x-1.x_html_1.patch698 bytes

Good catch. I think it makes sense to have both of those lines there be htmlspecialchars instead of check_url, since we're not presenting this as a clickable link: it's just text in the page. I've tested both versions, and they both seem fine.

HorsePunchKid’s picture

HorsePunchKid commented
StatusFileSize
new path_redirect-5.x-1.x_html_2.patch1.34 KB

Things are never as simple as they seem. The table displayed on the node edit page needs the same fix. Is the HTML Validator extension out for Firefox 3 yet?

HorsePunchKid’s picture

HorsePunchKid commented
Status: Reviewed & tested by the community » Fixed

Went ahead and committed #2.

sinasalek’s picture

sinasalek commented

I don't think so, firebug also is not available for firefox3 yet unfortunately.
Thanks for applying the patch

HorsePunchKid’s picture

HorsePunchKid commented

It's rather buried in the release notes, but Firebug 1.1b is compatible with Firefox 3. I've been using it for a few weeks now, and it's working fine.

sinasalek’s picture

sinasalek commented

Thanks HorsePunchKid i didn't know that :). and looks like firefox addon site is pretty much out of the date. HTML Validator for firefox 3 beta 5: http://users.skynet.be/mgueury/mozilla/download.html

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.