Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
dblog.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Jun 2005 at 01:34 UTC
Updated:
29 Jul 2014 at 17:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dries commentedThese queries are not secure. If someone manages to extend an administrator's session information (through a bug elsewhere), they would be able to execute SQL queries.
Comment #2
pyromanfo commentedWould moving it to the standard POST query paramater fix it?
Comment #3
dries commentedI wouldn't fix the problem. The solution is to properly use the dababase API. That is, to use the '%s' and %d directives.
Comment #4
killes@www.drop.org commentedlots of it. *shudder*
Comment #5
Jaza commentedthis would still be a useful feature. Moving to 6.x-dev queue.
Comment #6
catchPatch has no relationship to current module.
Comment #7
lilou commentedComment #8
deekayen commentedRather than maintain http://drupal.org/project/logsearch, perhaps I'll try rolling some small part of it into core.
Comment #9
deekayen commentedI guess I can't get this involved right now.
Comment #10
deekayen commentedComment #11
deekayen commented#445482: Convert dblog_build_filter_query() to DBTNG needs to be resolved before this can happen
Comment #12
deekayen commentedThis is where I was headed with this feature when I discovered #445482: Convert dblog_build_filter_query() to DBTNG. :s replacement doesn't work for u.name in this method because of the open bug. As this patch is, it would only add user searching, not text message text. Since the text portion of the watchdog log string has replacement values in it between the message and variables fields, that becomes a larger issue of discussion.
Comment #13
arhak commentedI don't know the way this patch goes, neither why it is postponed
but I'm providing patches and modules to achieve this
patch providing log_filters hook for D7 #582622: provide hook for dblog_filters
same patch for D6 #582672: dblog support filters through a hook (6.x)
alternatively a set of working modules for D6 #578488: recent/aged/username/hostname filters for log entries
(with screenshots available)
everything waiting for user to test and give feedback
do you really would like to see this into D7 core?
come on! code freeze is here already!
Comment #14
Alan.Guggenheim commentedIs the dblog / watchdog data available to views and / or rules / trigger /actions?
That would be great, as i need to do a lot of hand holding for user login and password reset. Could have better monitoring, automatic emails and reports,...
Comment #15
deekayen commentedComment #16
sun.core commentedComment #17
arhak commentedmarked #444654: admin/reports/dblog should allow filtering by user as a duplicate of this
Comment #18
treksler commentedshouldn't this be marked closed (won't fix) because who doesn't want to manually search through logs when they get about 2000 log entries per day.. finding that error message from last night should be an hour long endeavor, no?
Comment #19
Freso commented@treksler (and others): Help get #445482: Convert dblog_build_filter_query() to DBTNG in instead of being snarky.
Comment #20
pasquallethe watchdog data is available to views
#1874534: Introduce a dblog / watchdog views integration
#2015149: Replace dblog recent log entries with a view