The unit tester needs this. The patch only moves a few lines of code around so it's RTBC. I did check and things still work.

CommentFileSizeAuthor
#5 extensible_drupal_test_suite-249629-5.patch5.13 KBfloretan
#4 extensible_drupal_test_suite.patch2.88 KBchx
#3 extensible_drupal_test_suite.patch2.89 KBchx
#2 extensible_drupal_test_suite.patch2.89 KBchx
extensible_drupal_test_suite.patch2.45 KBchx

Comments

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

As a good habit, can we start adding some better PHPdoc to this code?

chx’s picture

chx commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new extensible_drupal_test_suite.patch2.89 KB

Yes.

chx’s picture

chx commented
StatusFileSize
new extensible_drupal_test_suite.patch2.89 KB

Crell did not like _foo. And I do not think we should really make that protected, so I just dropped an underscore.

chx’s picture

chx commented
StatusFileSize
new extensible_drupal_test_suite.patch2.88 KB

Also I am warned that methodName should not be method_name.

floretan’s picture

floretan commented
StatusFileSize
new extensible_drupal_test_suite-249629-5.patch5.13 KB

While reviewing I also fixed some comment style issues (most of which were not part of the patch). No functional changes.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.