Hi,

it would be nice if a cloned node would get a "clone of
" menu entry that was below the same parent menu as the original node.

cu,
Frank

CommentFileSizeAuthor
#22 249668-clone-menu-link-22.patch4.3 KBpwolanin
#20 249668-clone-menu-link-20.patch3.11 KBpwolanin
#17 clone_menu_v6.patch2.22 KBFrank Steiner
#16 clone_menu_v5.patch2.25 KBFrank Steiner
#13 clone_menu_v4.patch2.37 KBFrank Steiner
#11 clone_menu_v3.patch2.37 KBFrank Steiner
#10 clone_menu_v2.patch2.24 KBFrank Steiner
#2 clone_menu.patch2.25 KBFrank Steiner

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Postponed

Hmm, this might not be so hard for 6.x, but I'm really not sure this is a widely desired feature.

Anonymous’s picture

Anonymous (not verified) commented
Status: Postponed » Needs review
StatusFileSize
new clone_menu.patch2.25 KB

Hi,

we need that on our site, so I've made menu cloning a configurable option. You can activate "Clone menu entry" at the settings page for the clone module. The patch is conservative in that the option defaults to "off".

Maybe someone else finds it useful :-) It's against 6.x-1.0-beta2.

cu,
Frank

pwolanin’s picture

pwolanin commented

This could even be done a little more simply, though the code looks basically fine.

kristi wachter’s picture

kristi wachter commented

Just chiming in to say I definitely want this feature, and I hope you'll include the patch in the next release.

Thanks!

Kristi

cozzi’s picture

cozzi commented

Given the number of times I clone a menu (one for authenticated users and one for anonymous users) anything that would make that job easier would be a great help. If this feature will make light of this I too would use it.

guysaban’s picture

guysaban commented

Any chance you can make this patch for the latest version of the Node Clone module?

Frank Steiner’s picture

Frank Steiner commented

Not sure what you mean. The patch applies to the 1.0 and the latest -dev version?

guysaban’s picture

guysaban commented

I could not apply the patch. I must check my setup further before I make any comments. Thanks for the getting back to me.

Frank Steiner’s picture

Frank Steiner commented

It should be applied in the node_clone/ directory with "patch -p0 < clone_menu.patch"

Frank Steiner’s picture

Frank Steiner commented
StatusFileSize
new clone_menu_v2.patch2.24 KB

Bug fix. The menu entry didn't get the module-field set causing problems when re-editing a cloned node.

Frank Steiner’s picture

Frank Steiner commented
StatusFileSize
new clone_menu_v3.patch2.37 KB

Forgot to remove two fields from the cloned menu, causing the new menu entry to overwrite the old one (because it the same mlid).

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

Please conform to Drupal standard code style.

Frank Steiner’s picture

Frank Steiner commented
StatusFileSize
new clone_menu_v4.patch2.37 KB
pwolanin’s picture

pwolanin commented

see: http://drupal.org/coding-standards

e.g.:

$new_menu['has_children']=0;

You might also want to use: http://drupal.org/project/coder

Frank Steiner’s picture

Frank Steiner commented

I'm sorry :-( I AM using the coder module and it didn't return any more warnings for my _v4 version, so I relied on this. My version might be outdated, I will check, and try to work on it manually otherwise...

Frank Steiner’s picture

Frank Steiner commented
StatusFileSize
new clone_menu_v5.patch2.25 KB

Ok, coder indeed doesn't find the "x=y" problem, using the latest dev from Jan 21. I was just relying on this, my fault!

I've checked against the coding standards weg page and corrected some indents, the assignments etc. I hope everything is correct now. I'm really sorry about this!

Frank Steiner’s picture

Frank Steiner commented
StatusFileSize
new clone_menu_v6.patch2.22 KB

I've re-worked the patch and changed the direction of the menu creation, i.e., I start with a default menu object and fill in only those values that you can enter in the form. I hope this will be more "future-safe" than cloning the existing menu item and resetting those settings that I'm currently aware of. Those "hidden" settings might change more often.

attheshow’s picture

attheshow commented
Version: 6.x-1.0-beta1 » 6.x-1.0
Status: Needs work » Reviewed & tested by the community

Patch in comment #17 worked great for me. RTBC!

pwolanin’s picture

pwolanin commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

Seems like it needs work - for example, you are not unsetting the mlid.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 249668-clone-menu-link-20.patch3.11 KB

Ah, I see - the mlid is 0. Still, menu_link_save() sets all the defaults, so I think we can skip the extra prepare call.

also, terminology is a bit confused - we are cloning the menu link.

pwolanin’s picture

pwolanin commented

need to add the new variable to hook_uninstall

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed
StatusFileSize
new 249668-clone-menu-link-22.patch4.3 KB

committing this patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Frank Steiner’s picture

Frank Steiner commented
Status: Closed (fixed) » Needs work

Hi,

sorry for reopening such an old fix, but I've to admit that I didn't test your patch well enough. At the first glance it seems the menu is cloned correctly because in the edit form the menu entry is visible right after the clone (on the initial edit of the node).

But when you re-edit the cloned page after saving it, the menu entry is no longer shown in the node edit form. It is still a available in the menu edit form, but it has only "edit" and no "delete" link available.

The reason is the "module" column. With the current code, the column is empty for a cloned menu entry. For a newly created node it has the value "menu". Now when I debugged that I remember that I stumbled on this issue long time ago when I wrote the patch. I didn't want to write 

$node->menu['module'] = "menu";

because I thought "what if the value ever changes, or there are some other things that must be set?". Therefore I called 

node_invoke_nodeapi($node, 'prepare');

trusting that it would set all things like the module column to the correct values :-)

Setting the module column to "menu" manually for a cloned menu entry makes it deletable in the menu edit form and also shows it again in the node edit form. Thus, we must either set 

$link['menu_name']="menu";

in your patch, or call the nodeapi prepare code.

cu,
Frank

Frank Steiner’s picture

Frank Steiner commented
Status: Needs work » Fixed

Just saw that you fixed this in 1.3 by

 $link['module'] = $old_link['module'];

I was still using -1.2 so I missed the fix :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.