Closed (fixed)
Project:
Link checker
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Reporter:
Created:
22 Apr 2008 at 12:09 UTC
Updated:
15 Feb 2009 at 17:30 UTC
Jump to comment: Most recent file
This is a very neat module and complements:
http://drupal.org/project/link_checker
It would be great if the two could be merged, with options to check content_types/fields as necessary.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | linkchecker.patch | 25.97 KB | hy0kl |
| #4 | linkchecker.install.patch | 5.3 KB | hy0kl |
Comments
Comment #1
momper commented+1
Comment #2
jredding commentedI maintain link_checker and I'd like to merge it with this project. Yes/No?
So far what I can see is that we would need the following changes
1) the admin settings page would need to include CCK specific items, like which content types to search. A setting like this could also be beneficial for this module overall as people may not want to search every node.
2) The table needs to be expanded or a new table added. the link_checker module table has the following fields
vid (version id)
nid (node id)
delta (delta of the link as a single node may have multiple links)
last_checked (last time this link was checked so we can do rechecking of links)
status (HTTP status code)
field_name (which particular field is used for this link, a node could have multiple link fields)
error_count (threshold of how many times we recheck a link before calling it dead)
So far other than that its just a philosophy on how to merge these, which functions to reuse. You're link checking code looks a bit better so I'd just plug into that. Or in short my changes would be
1) Add administrative settings
2) Add CCK checking code into hook_cron
3) Pass URLs off to be checked as "tasks"
4) modify as appropriate such that the exact link in the URL is monitored (vid, nid, delta, field_name together make a key)
Thoughts?
Comment #3
jredding commentedping.. ping..
Comment #4
hy0kl commentedHi.
I merged link_checker and linkchecker, and modified the linkchecker module's code style just use drupal code style. So the patch is very big, I am sorry for it.
New module named linkchecker, it contains all of functionality of original link_checher and linkchecker modules.
Any question, please connect me. Thank you.
Comment #5
hy0kl commentedupdate the patch files.
Comment #6
hass commentedsubscribe
Comment #7
janusman commentedsubscribe
Comment #8
hass commentedI'm working on a redesigned D6 version of this module - hopefully with CCK support in the first available DEV. Afterwards we can backport this to D5.
Comment #9
hass commentedI need some help for the CCK stuff. I tried some time, but have not yet got what I need + I'm not sure about the table structure... Maybe create
linkchecker_node_fieldwithfield_name, lidcolumns. I've committed the latest code to CVS for review, but CCK stuff is still missing. I've nevertheless added some conditions inlinkchecker_nodeapi()where we need to scan the CCK fields for URLs first.Comment #10
hass commentedFixed for D6. http://drupal.org/cvs?commit=168404
Comment #11
hass commentedComment #12
hass commentedComment #13
hass commented