_feedapi_export_opml() is not a form however feedapi_menu() thinks it is. Fix is attached.

Comments

aron novak’s picture

Title: _feedapi_export_opml() is not a form » OPML exporting - how to do smart? (help needed!)
Assigned: Unassigned » aron novak
Category: bug » task
Status: Needs review » Active

Thanks, your patch is applied.
I have a question:
Now _feedapi_export_opml just print out the opml content and let other modules to totally mess up the things. Is it generally a good idea to insert a flush() / exit() to the end of the function? I'm in doubt. The current situation is not good, because everyone else can brake the opml result. But the exit() is extremely hard solution, some modules maybe expect normal drupal "shutdown". Is there a good way?

mustafau’s picture

StatusFileSize
new2.72 KB

Core aggregator uses theme() function for OPML export. I copied and pasted theme_aggregator_page_opml() function to feedapi however it is not working for me. Can you test this patch?

mustafau’s picture

Status: Active » Needs review
StatusFileSize
new2.82 KB
new2.82 KB

I have found the problem with previous patch.

Following patch implements feedapi_theme() function. Other parts are identical to above patch.

mustafau’s picture

StatusFileSize
new2.73 KB

Updated patch to keep up with latest changes.

aron novak’s picture

Status: Needs review » Fixed

Thanks for the patch.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.