_feedapi_export_opml() is not a form however feedapi_menu() thinks it is. Fix is attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | theme_feedapi_export_opml.patch | 2.73 KB | mustafau |
| #3 | theme_feedapi_export_opml.patch | 2.82 KB | mustafau |
| #2 | theme_feedapi_export_opml.patch | 2.72 KB | mustafau |
| feedapi_export_opml-is_not_form.patch | 1 KB | mustafau |
Comments
Comment #1
aron novakThanks, your patch is applied.
I have a question:
Now _feedapi_export_opml just print out the opml content and let other modules to totally mess up the things. Is it generally a good idea to insert a flush() / exit() to the end of the function? I'm in doubt. The current situation is not good, because everyone else can brake the opml result. But the exit() is extremely hard solution, some modules maybe expect normal drupal "shutdown". Is there a good way?
Comment #2
mustafau commentedCore aggregator uses theme() function for OPML export. I copied and pasted theme_aggregator_page_opml() function to feedapi however it is not working for me. Can you test this patch?
Comment #3
mustafau commentedI have found the problem with previous patch.
Following patch implements feedapi_theme() function. Other parts are identical to above patch.
Comment #4
mustafau commentedUpdated patch to keep up with latest changes.
Comment #5
aron novakThanks for the patch.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.