Thanks for this D6 port, it's working well for me.

Just one question re: themeing the tab markup...

I use a flexible tab layout for my sites that makes use of one additional wrapped around the actual tab text. I looked through the code hoping to find a theme hook for the tab markup that I could override, but it looks as though it's just hard coded in the block hook.

Would you be opposed to breaking that portion out into a theme hook call? If so, and you don't have time, I'd be willing to write the patch if you'd consider it. I'd just prefer not to hack your code up whenever there's an update. :)

Thanks, it's a nice module :)

Comments

katbailey’s picture

katbailey commented

Hi there,
yes, i had thought about this and whether I should use a theme function for the mark-up. The reason I didn't do that was because the relationship between the li elements for the tabs and the div elements containing the content needs to be maintained in order for the jquery to work and so if somebody overrides the markup they could destroy this relationship. But I guess I could put a comment in the theme function to this effect (i.e. override at your own risk! ... or something). At least this means people could add their own classes. I may be able to change the jQuery somewhat so that it doesn't require quite as strict a relationship, e.g. so that adding one extra wrapper around the tab text wouldn't break it.

Katherine

Moonshine’s picture

Moonshine commented

**removing my blinders** Ahh yes, very true. I'm just wrapping a span around the tab text, so everything still works fine, but I certainly see your point. I'm probably a fringe case though, and I'm sure Views2 is probably higher on your list. :)

However, if your bored some night and want to pull the loop out into a theme hook, I would certainly be grateful. Feel free to plaster it with a big disclaimer about how the changing the hook could break things. Really every Drupal hook should have one. :D

katbailey’s picture

katbailey commented
Status: Active » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.