I just upgraded to the latest stable branch. In place of the the messages we used to get and that were fixed http://drupal.org/node/194204, I now see unknown when I log in to my Drupal site.

>
function drupalvb_msg($msg, $arg = 'unknown') {
  switch ($msg) {
    case DVBERROR:
      drupal_set_message('Error: '. $arg);
      break;

    default:
     drupal_set_message($arg);
  }
  return;
}

If you remove the default: value, the message "unknown" does not show. I've attached a patch.

CommentFileSizeAuthor
unknown_hiding_drupalvb.patch412 bytesstevenpatz

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

Thanks. Please consider testing 5.x-2.x.

stevenpatz’s picture

stevenpatz
he/him
commented
Title: "Unknown" now displayed in place prrevious messages. » "Unknown" now displayed in place previous messages.

I am not familiar with the 2.x code base. The code is really different but I did find this:

 function drupalvb_action_handler($op = NULL) {
   switch ($op) {
     case 'export':
       drupalvb_export_drupal_users();
       drupal_set_message(t('Drupal users have been exported to vBulletin.'));
       break;

     default:
       drupal_set_message(t('Attempted to perform an unknown action.'), 'error');
       break;
   }
   drupal_goto('admin/settings/drupalvb/actions');
 }

If that controls the output message then the default: value would need to be removed as well. I can create a patch for that, if that's correct. If it is not, then I don't think the original issue is in the development code.

stevenpatz’s picture

stevenpatz
he/him
commented
Title: "Unknown" now displayed in place previous messages. » "Unknown" now displayed in place of previous messages.
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Yes, drupalvb_msg() has been removed from 5.x-2.x. That's why I suggested to consider using/testing 2.x. The plan is to mark 5.x-1.x as unsupported when 5.x-2.0 has been released.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (won't fix)

5.x-2.x is the recommended major version now.