Connection breaks when user name changed

If users are allowed to change their user name in Drupal, the connection to vBulletin through DrupalvB will break. To avoid this problem, make the following changes in your code:

Step 1) Find the following line in drupal_vb.module (around line 620):

_drupalvb_update_vb_user($edit_user->name, md5($edit['pass']), $edit['mail'], $userinfo['salt']);

And change it to this:

_drupalvb_update_vb_user($edit_user->name, $edit['name'], $edit['pass'], $edit['mail'], $userinfo['salt']);

By making this change you are passing both the existing user information ($edit_user) and the new user information ($edit) to the _drupalvb_update_vb_user function. I also have removed the md5 from the function call above since I seemed to have some problems with it, and have read on other posts to remove it. Not sure what the current developers think.

Step 2) Find the following line in drupalvb.inc.php (around line 196):

function _drupalvb_update_vb_user($username, $password, $email, $salt) {

And change it to this:

function _drupalvb_update_vb_user($orig_username, $username, $password, $email, $salt){

$orig_username is the original username that we are passing over to this function as reference.

Step 3) Find the following line in drupalvb.inc.php (around line 208):

db_query(_drupalvb_prefix("UPDATE {user} SET password = '%s', passworddate = '%s', salt = '%s', email = '%s', lastactivity = '%s' WHERE username = '%s'"), $passhash, $passdate, $salt, $email, $lastdate, $username);

And change it to this:

db_query(_drupalvb_prefix("UPDATE {user} SET username = '%s', password = '%s', passworddate = '%s', salt = '%s', email='%s', lastactivity = '%s' WHERE username = '%s'"), $username, $passhash, $passdate, $salt, $email, $lastdate, $orig_username);

So this code updates the user name in vBulletin in the case where we find a match for the $orig_username and $username <> $orig_username.

Step 4) Find the following line in drupalvb.inc.php (around line 211):

db_query(_drupalvb_prefix("UPDATE {user} SET email = '%s', lastactivity = '%s' WHERE username = '%s'"), $email, $lastdate, $username);

And change it to this:

db_query(_drupalvb_prefix("UPDATE {user} SET username = '%s', email = '%s', lastactivity = '%s' WHERE username = '%s'"), $username, $email, $lastdate, $orig_username);

This ensures username is updated if there is a difference between $orig_username and $username. Let me know if there are any questions.