We don't include third-party source code in CVS, as this can lead to tricky licensing issues. Please remove it as soon as possible. Thanks!

Comments

mlsamuelson’s picture

cwgordon7,

markItUp is licensed as MIT/GPL, like jQuery itself. There are other modules that have been around in the Drupal CVS repository for some time (jCarousel and Thickbox, to name a few) that include the source code of jQuery plugins. So, I'm asking, how is it this case is different?

mlsamuelson

liam mcdermott’s picture

This module is an instance where third-party code is acceptable. In particular: 1. it is available under the same license as Drupal; 2. changes need to be made to markitup code to make it work with Drupal. It is unfair to expect users of this module to download and change third-party code to make this module work.

I can dig-up the conversation on the dev mailing list to support this point of view if required. :)

mlsamuelson’s picture

Status: Active » Closed (won't fix)

Thanks for the context, Liam.

I've been working with markItUp 1.1 (which doesn't have public release yet and isn't reflected in the current version of markItUp in CVS, but will be as soon as the markItUp developer releases 1.1 publicly) and things are coming along well, but for the sake of having multiple sets (buttons and syntax support), it will be necessary to alter a few namespaces here and there for the sets - which is the desired way to manage multiple sets in markItUp. Being able to do most of this work up front for the users will mean that I don't spend the rest of this module's life in the issue queues explaining that the user needs to download a plugin, rename a the skin and set's CSS files, and then edit a JS file to alter a namespace. It's not difficult stuff, but would be the sort of thing novices would get hung up on, so I'm glad to see that Drupal's policy will support what is A. best for developers, and B. best for users.

I'm changing this to won't fix. If anyone has further concerns, though, please mark active again.