If I have only chosen to a single messaging transport (eg Simple Mail or PHPMailer), It would be nice if the "Default send method:" (found in your user account setting) select box were hidden. There's no reason (IMO) to give a user a option that only has one option, as it will just adds noise and confusion :)

I was planning on submitting a similar request over in the messaging queue, but I wanted to wait to get you feedback here first.

Just a request, but thanks for all your hard work on this module.

CommentFileSizeAuthor
#11 messaging-hide-user-form-if-only-one-method.diff1.04 KBlandry
#1 messaging.module.250161.patch2.22 KBjaydub
#1 notifications.admin_.inc_.250161.patch1.35 KBjaydub
#1 notifications.module.250161.patch1.33 KBjaydub

Comments

jaydub’s picture

jaydub commented
Status: Active » Needs review
StatusFileSize
new notifications.module.250161.patch1.33 KB
new notifications.admin_.inc_.250161.patch1.35 KB
new messaging.module.250161.patch2.22 KB

Yes I do think that there's room for improvement here.
I've attached patches for messaging and notifications
to address this in the module settings pages and in
the user edit pages.

I know Jose is porting to Drupal 6 at this time so I'll
post the patches here to be assessed rather than
just commit.

jose reyero’s picture

jose reyero commented
Status: Needs review » Patch (to be ported)

The patches look good. However I think it was asking for a bigger remake so that's what I did.

Merged messaging and notifications 'default_send_method' setting, it should show up disabled when there's only one. Also fixed some related issues, strenghtened permissions (aditional checking in case perms have changed), etc...

This is to be ported to D6. There may be room for more improvements though (Like actually removing the send method down for subscription forms)

jose reyero’s picture

jose reyero commented
Status: Patch (to be ported) » Closed (fixed)

Done for D6

plan9’s picture

plan9 commented

@Jose, do you have this patch for D5?

amogiz’s picture

amogiz commented

Hi. I am a user of this great D6 module but still have the send box method down for subscription forms.
How could i hide it ?
Thanx

amogiz’s picture

amogiz commented
Version: 5.x-1.x-dev » 6.x-2.2
Status: Closed (fixed) » Active

Excuse me i did not fill correctly the form and did not re-open the Post so i do it again.

Hi. I am a user of this great D6 module but still have the send box method down for subscription forms.
How could i hide it ?
Thanx

jdln’s picture

jdln commented

Subscribing.

Soldierka’s picture

Soldierka commented

I can't find this option neither.... Any help please?

jdln’s picture

jdln commented

If there was a div with a unique name around these options so I could hide it with CSS, that would be fine for me. Is there a simple patch / theming method to achieve this?
Thanks

juc1’s picture

juc1 commented

same problem here

landry’s picture

landry commented
Status: Active » Needs review
StatusFileSize
new messaging-hide-user-form-if-only-one-method.diff1.04 KB

I think what people want is no form at all if there is only one method available. Atm, the form is here, but with a disabled select box.

A 'better' fix would be removing '#disabled' in messaging.module:messaging_user() line 138, and instead amend the if to be :
if ($category == 'account' && ($list = messaging_method_list($user)) && count($list) > 1)

Attached patch works for me.