Access log fields should support sorting, filters, and arguments.

Priority set to critical, as this is needed to get past the shortcommings of the built in reports.

This is a nice and simple task within my skill set, so I will try to get a patch out for it.

CommentFileSizeAuthor
#1 views_accesslog_filters.patch2.22 KBRoboPhred

Comments

RoboPhred’s picture

RoboPhred commented
Category: feature » task
StatusFileSize
new views_accesslog_filters.patch2.22 KB

Here is the result of a few minute's work.
I tested all the filters, but not the arguments.

A bit more thought might be needed for session id and path. I was not sure if they should get argument or filter.

Is the "Access Log: User" different from "User: Name" that is also available from the Access Log view type? At any rate, the access log user field needs handlers.

I don't know if it was somthing I changed, but I am getting an error when I add "Access Log: Timer" as a filter. I am fairly certain it wasn't me, though.

merlinofchaos’s picture

merlinofchaos commented
Priority: Critical » Normal

One quick note is that this doesn't appear to be a completely proper patch -- it doesn't have the header I expect. You need to use 'cvs diff -up' to generate patches, if at all possible.

For the most part this looks ok, but I'm pretty tired right now so haven't given this a full review. This IMO isn't critical but it is interesting and useful so is likely to get in in some form or another.

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Needs review
merlinofchaos’s picture

merlinofchaos commented

Unfortunately, this patch does not apply because it wasn't created with the proper options. I can try to apply it manually but it'd be nicer if you could reroll it.

In addition, you have a comment about needing the user name -- what you really want to do is create a relationship to the accesslog user. If that's beyond you, I understand; reroll the patch and I'll add that part in.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work
merlinofchaos’s picture

merlinofchaos commented
Status: Needs work » Fixed

Nevermind, I had to do some other work in this file so I went ahead and folded your changes in.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.