Hi,
we definitely need this module for our 6.x site. How are the chances that you will release a 6.x version?

cu,
Frank

CommentFileSizeAuthor
#5 checkout-D6.patch13 KBsmk-ka
#4 checkout_6_x.patch10.39 KBFrank Steiner

Comments

Anonymous’s picture

Anonymous (not verified) commented

Hmm, I guess two weeks of silence is kind of a "quite small" ? :-)

AaronCollier’s picture

AaronCollier commented

Marked #255226: for drupal 6.* ? as a duplicate.

joel_guesclin’s picture

joel_guesclin commented

Try asking jgraham, I believe he uses the module. I am not actively maintaining it myself. Sorry I can' t be more help.

Anonymous’s picture

Anonymous (not verified) commented
Title: Upgrade to 6.x? » First try for 6.x, please test
Version: master » 5.x-2.x-dev
Assigned: Unassigned » Frank Steiner
Status: Active » Needs review
StatusFileSize
new checkout_6_x.patch10.39 KB

Don't mind ;-) I just finished the patch for making it work in 6.x this afternoon. I hope someone will test it as it seems the demand for a 6.x version is quite small (I don't get it...how can anyone seriously work without it? :-))

The patch is against checkout-5.x-2.x-dev.tar.gz from March 27, 2008.

Apart from changing the code to reflect the new api, I also added a check for 'validate' in nodeapi, i.e., before a node should be saved. We must check if we still have the lock, because it could happen that someone starts editing a node and then goes out for lunch for some hours.
Now cron might remove the lock in the meantime and user 2 might start editing. But if user 1 returns from lunch and saves the node, it will succeed and user 2 will get a "content has been modified, cannot save" although he has the lock. With the new check, user 1 will be informed if someone else is currently editing (could still happen that user 2 aborts his edit so that user 1 can finally save) or if the node has been changed in the meantime. If the lock was just lost without anyone else changing or locking the node, the lock can be regained to save the changes.

smk-ka’s picture

smk-ka commented
StatusFileSize
new checkout-D6.patch13 KB

Thanks, Frank, for making the first move! I'm unfortunately bound in a large project (still on D5), nevertheless I've happily reviewed your patch and fixed a couple of things:
- Removed menu titles from callback menu items (useless because never shown).
- Removes t() calls from menu titles (now automatically translated by the menu system).
- Fixed release link not displayed if the node is locked by the same user (in checkout_node()).
- Slightly simplified nodeapi('validate') (removed a rather odd error message).
- Updated hook_help to D6.
- Changes to wording (since D6, we don't say 'cron' and 'node' to our beloved users anymore).
- Fixes to coding standards.

Patch is untested, though, and .info file has been intentionally left out (use from Frank's patch or edit yourself).

Anonymous’s picture

Anonymous (not verified) commented

Hi smk-ka,

sorry for those things, I guess you can see that I don't have that much experience in drupal coding :-) I learn most of the things from looking at other modules. I will learn about the coding standards!

I will test your patch, thank you!

Anonymous’s picture

Anonymous (not verified) commented

Your version works fine for me!

joel_guesclin’s picture

joel_guesclin commented

Would someone like to take the completed D6 code and make a D6 version for publication and download?

smk-ka’s picture

smk-ka commented
Status: Needs review » Fixed

Done.

Anonymous’s picture

Anonymous (not verified) commented

Great, thanks!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.