Closed (fixed)
Project:
FeedAPI
Version:
6.x-1.x-dev
Component:
Code feedapi (core module)
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
24 Apr 2008 at 19:07 UTC
Updated:
2 Oct 2009 at 07:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
eyecon-1 commentedI am changing this to a bug. I have reviewed the OPML spec and removed title from the HEAD. The results are exactly the same. Moreover, the OUTLINE format conforms to the manner in which FeedAPI exports OPML.
Comment #2
eyecon-1 commentedRemoved
<?xml version="1.0" encoding="utf-8"?>Removed tags between
<head> and </head>Outline tags limited to xmlURL. In other words, no title or text tags. With these tags, whether checked or unchecked the respective fields on the import OPML form break the process.
A few of the feeds were not added. Should these failures be logged (they are not)? With a bunch of feeds, it becomes problematic to identify those that were not added.
Comment #3
aron novakYes. Sorry. The OPML parsing in FeedAPI is really useless. It expects exactly this string: "<?xml version="1.0"?>" .
Because Drupal 6 is php5 only, OPML import has to use SimpleXML also.
Sorry, i do not have time now to fix an inherently not good solution. I can promise you a whole new OPML processing code soon.
I'll add the weakness of the OPML import to the release notes.
Comment #4
Robin Millette commentedDo you mean FeedAPI for Drupal 6 is PHP 5 only? Because otherwise, Drupal 6 runs PHP 4 and 5. Drupal 7 will be PHP 5 only though.
Comment #5
aron novakRight, can't be done because of php compatibility level of drupal
Comment #6
aron novakThese are should be avoided for example.
Comment #7
aron novakeyecon: i just used your example opml file in the initial post and filled with an example URL and it just worked.
However i found out that the OPML return messages are really awkward sometimes.
If the all of the feeds in the opml files are exist, the error msg about the valid feed appeared. Here is a patch to fix this.
Can you attach a whole opml file that you can't import? And where the feeds are not in the feedapi table. In that way, i would be able to debug deeper.
Comment #8
alex_b commented"All of the feed URLs are already exist in the FeedAPI table."
"All of the feed URLs already exist in the FeedAPI table."
-> otherwise good to go.
Comment #9
aron novakcommitted