Fatal error during instal in 'ec_mail_implementor_list', tries to call 'store_mail_types'

During a 'typical install' I selected the modules I wanted and hit submit. I was then told that I'd not selcted some dependencies... So I clicked proceed to have them enabled for me... I then got a White-Screen-O-Death...

I checked my error logs and found this:

2008-04-25 12:13:02: (mod_fastcgi.c.2592) FastCGI-stderr: PHP Fatal error:  Call to undefined function store_mail_types() in /var/www/html/www.4hd.net/drupal/sites/www.4hd.net/modules/ecommerce/ec_mail/ec_mail.module on line 458

So I jumped onto that line and its referring to this section of code...

  foreach ($modules as $module) {
    $function = $module .'_mail_types';
    foreach (array_keys($function()) as $type) {
      if (in_array($type, $types) or !count($types)) {
        $imps[$type] = $module;
      }
    }
  }

So this function looks for hooks and then tries to run them, simply assuming they exist... So I changed it to:

  foreach ($modules as $module) {
    $function = $module .'_mail_types';
    if (function_exists($function)) {
      foreach (array_keys($function()) as $type) {
        if (in_array($type, $types) or !count($types)) {
          $imps[$type] = $module;
        }
      }
    }
  }

The issue has now disappeared. So the 'patch' in this case is simple to wrap the foreach in a condition that the function exists... I kinda figured there was little point creating a patch file for this as it'd be just as easy to apply yourself :-)

Nick