help.test needs a cleanup
catch - April 25, 2008 - 15:13
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | tests |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs work) |
Description
help.test has several assertions commented out, notably to do with blog and poll modules. It's not clear whether these are broken bits of test or broken bits of code, but we should fix it.
#1
The existing test assumes that every enabled module implements hook_help(), and also uses assertions that could be influenced by external settings (site name, theme, etc).
The help module doesn't provide much besides the implementation of hook_help, and that hook has very loose requirements. The only way to figure out if a module will display help on a certain page is to call its help hook and see if something is returned. There is no guarantee that a module implementing hook_help will display anything on any page.
Here's a patch that works, but I'm still not satisfied with the approach. I'm working on a dummy module whose only purpose would be to test hooks, but that's a different issue.
#2
Change component is relation to http://drupal.org/node/253744.
#3
The issues were stated here, but never fixed: http://drupal.org/node/242475.
#4
No longer applies. 1 out of 2 hunks failed.