Using the JS aggregator module makes the panels UI break. When you click on the "add argument" or "add context" form buttons on a node override panel setup, nothing happens. A settings dialog is supposed to appear, of course.

CommentFileSizeAuthor
#4 panels-DRUPAL-5--2.js-aggressor.patch12.05 KBsun
#1 panels-DRUPAL-5--2.js-aggressor.patch12.04 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 5.x-2.x-dev » 5.x-2.0-beta3
Component: User interface » Code
Category: task » bug
Status: Active » Needs review
StatusFileSize
new panels-DRUPAL-5--2.js-aggressor.patch12.04 KB

Attached patch should fix this issue.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs review » Reviewed & tested by the community

It is interesting that I can't replicate this bug. Using Panels (HEAD) with the JS aggregator, the modals still work well, with or without sun's patch. I doublechecked in Firebug and yes, the JS got correctly aggregated.

@NikLP: Does the patch fix the issue for you? Does the bug reoccur if you un-apply the patch?

The patch corrects coding style though, so it should be anyway committed.

niklp’s picture

niklp commented

That is interesting... I'll be honest, I'm not sure if we have applied this yet. I know that I took panels.js "out" into the exceptions box in the JS agg settings, and aggregation worked again, but it has been a while since we tried it without this setup. I will have to re-investigate, but the fact that Sun has donated a patch sort of implies that there was a potential problem.

I will try (when time/stage server permits) to implement the patch and again without. Thanks for the update.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 5.x-2.0-beta3 » 5.x-2.0-beta4b
StatusFileSize
new panels-DRUPAL-5--2.js-aggressor.patch12.05 KB

Re-rolled against latest DRUPAL-5--2.

sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Needs work

See, now, I have a different report: this patch breaks all the js on the content editing form for me. The layout_settings form js still works, but everything on the content editor is borked.

sdboyer’s picture

sdboyer commented
Status: Needs work » Fixed

Nevermind, there was a typo in one of the changes made by the path that broke the whole display_editor.js file. Fixed now, and we're good to go; changes have been committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.