You get a php error on php5 with 5.x-2.3

line 769: Illegal argument to foreach

simple fix, wrap foreach in an if:

if (is_array($ops))
{
foreach ($ops as $op => $description) {
$forms['actions_'. $hook .'_'. $op .'_assign_form'] = array ( 'callback' => 'actions_assign_form' );
}
}

Comments

jvandyk’s picture

jvandyk commented
Status: Needs review » Closed (duplicate)

http://drupal.org/node/236908

jefkin’s picture

jefkin commented
Project: Actions » Devel
Version: 5.x-2.3 » 6.x-1.16
Component: Code » devel_themer
Status: Closed (duplicate) » Active

This is probably already reported, but I'd didn't spot it.

Conflicts exist between devel_themer in the Devel module(which appears to includes a few versioned jquery ui files) and the Jquery_ui module, which allows a site to use specific (often newer) versions of the jquery_ui.

I propose that devel_themer ads some small logic on the order of:

if (module_exists('jquery_ui'))
{
  jquery_ui_add('ui.core');
  jquery_ui_add('ui.mouse');
  jquery_ui_add('ui.draggable');
}
else
{
  drual_add_js('...'); // what currently is: ui.mouse.js, and ui.draggable.js
}

My option has been to expect my jquery ui stuff to fail whil I have the themer turned on.

Thanks for your consideration.

jefkin’s picture

jefkin commented
Project: Devel » Actions
Version: 6.x-1.16 » 5.x-2.3
Component: devel_themer » Code
Status: Active » Closed (duplicate)

Sorry, ignore above this, I pasted in the wrong box