Standardise biblio_access

gustav - April 25, 2008 - 19:44
Project:Bibliography Module
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Currently biblio_access grants explicit view access to all users who are not explicitly forbidden to access it. This makes it impossible for node access modules to control access to biblio entries. I propose that access to biblio nodes should be handled in the same way as access to other nodes (see http://api.drupal.org/api/function/node_content_access/5) so that if there is no overriding reason to grant or deny access biblio_access should return NULL so that the node_grants mechanism can kick in.

The patch attached is for the DRUPAL-5 branch.

AttachmentSize
biblio.module.patch1.61 KB

#1

gustav - April 25, 2008 - 19:47
Status:active» needs review

Sorry, the previous patch contained some spurious code. The newly attached patch is clean.

AttachmentSize
biblio.module.patch 1.26 KB

#2

rjerome - April 26, 2008 - 01:32
Status:needs review» fixed

Fair enough, the change has been made.

Ron.

#3

Anonymous (not verified) - May 10, 2008 - 01:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.