Imported translations are marked as 'suggestion' if there are existing translations. Can we add an option to directly set these imports as active translations (existed ones will moved to suggestion)? Of course we will only want to open this option to users with 'approve translations' permission.

Comments

gábor hojtsy’s picture

Version: 5.x-1.0-alpha3 » 6.x-1.x-dev
Component: Code » Import

Well, currently this allows you to resolve conflicts (in fact it forces you to resolve them), while otherwise it would be easy to overlook these. If we'd keep the preexistent translation as a suggestion, you'd need to perform the same administrative steps anyway to clean out your suggestions pool, so I'm not sure this helps much beyond getting the updated translations into the DB faster. What do others think?

BTW the code in question is this from import.inc:

      if ($translation && (empty($translation->translation) || ($translation->translation != $value['msgstr']))) {
        // If we have an empty translation placeholder (ie. no translation yet,
        // but unresolved suggestions are there), or if we have some translation
        // already, which is different from what we save now, redirect the data
        // to be a suggestion instead. This allows conflict issues to be resolved.
        $is_suggestion = TRUE;
      }
gábor hojtsy’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Active » Closed (duplicate)

The 6.x-2.x branch now cleans up this code and makes it work more like you've requested. Now strings are only marked suggested when you ask to import suggestions or a string was #fuzzy in the .po. So this can be considered fixed.