Support functions returning references

Damien Tournoud - April 26, 2008 - 12:58
Project:API
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

In the Drupal 6+ codebase, we have to functions returning references (&_batch_current_set() in includes/batch.inc and &batch_get() in includes/form.inc). The parser currently does not support that, and this leads to an empty function name being parsed (see it live on api.drupal.org).

Here is a patch that fix the issue.

AttachmentSize
api-reference-functions.patch794 bytes

#1

Damien Tournoud - April 27, 2008 - 10:29
Status:active» needs review

Setting as patch need review.

#2

Damien Tournoud - May 29, 2008 - 20:47
Title:API Parser does not support functions returning references» Support functions returning references

Clarify the title.

#3

neochief - May 31, 2008 - 08:04

I've tested this patch, it not works for me. The &batch_get simply not appears in lists at all.

#4

neochief - May 31, 2008 - 08:28
Status:needs review» reviewed & tested by the community

Ah, sorry, I didn't notice that batch_get appears without ampersand. At this point, all works fine.

#5

drumm - June 15, 2008 - 22:21
Status:reviewed & tested by the community» fixed

Committed to HEAD.

#6

Anonymous (not verified) - June 29, 2008 - 22:23
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#7

bobthecow - August 15, 2008 - 21:42

the same change should be made in the "// Find undocumented functions." section of parser.inc as well...

#8

drumm - August 15, 2008 - 21:46
Status:closed» active

#9

Damien Tournoud - August 15, 2008 - 21:54
Status:active» fixed

This has been done by drumm during the commit [1].

[1] http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/api/parser....

#10

Anonymous (not verified) - August 29, 2008 - 22:03
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.