Closed (duplicate)
Project:
Glossary
Version:
5.x-2.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Apr 2008 at 22:58 UTC
Updated:
26 Apr 2008 at 23:35 UTC
Viewing the glossary overview my whole layout broke.
I found out that there is one closing div too much.
I tracked down the bug to function glossary_overview.
$output = '<div id="'. strtr(drupal_strtolower($vocab->name), $tbl) .'">';
if ($vocab->description) {
$output .= '<p class="glossary-description">'. $vocab->description .'</p>';
}
else {
$output = null;
}
My $vocab->description is not set. Therefore $output is set to null.
The function returns always return $output .'</div>'; but since $output was set to null the opening div vanishes, so there is a closing div too much.
I attach a patch removing the "else".
I don't know why this else is there, so maybe this is a bad idea ?
Please review.
| Comment | File | Size | Author |
|---|---|---|---|
| glossary.module.overview-bug.patch | 425 bytes | Andreas Wolf |
Comments
Comment #1
nancydruhttp://drupal.org/node/241114
Try the -dev version.
Comment #2
nancydruI just rolled new official releases too.