Make ATCK BIDI
| Project: | Advanced Theme Construction Kit (ATCK) |
| Version: | 6.x-2.2 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Hi Caleb,
Thanks for a very interesting project.
I was thinking that it would be good to make ATCK Bidirectional, since it can be the base layer for many BIDI sites that way. I am working on a BIDI site, but I am no pro, so I need a good foundation. And a theme like Garland is simply too clever in many ways to start out with and I don't like that. I also want something simple that doesn't break when I increase the font size (like 99% of all downloadable themes including Garland).
So ATCK is perfect if only it would have BIDI support (I mean . I created a style-rtl.css file that I will send you (don't want to post it here give these licence issues). It does 90% of the job for me already. The alignment of menus is a bit weird. Perhaps fixing that is a breeze for you (like I said I'm not a pro). I only tested it on two layouts, so it might not work for you.
Thanks,
rvk
#1
Hi rvk,
I'd love to see atck be bidirectional, but I don't have any time to work on it, or even much a particular need with my current development work. I would be glad however to accept patches if anyone wants to roll one. :-)
Regards,
Caleb
#2
Too bad you don't have the time yourself. Like I said I did part of the job (I think anyway). Someone (with more css skills) should have a look at it though. Can I post it here (given the licence issues)? Well you should have it in your inbox too.
rvk
#3
Hi rvk,
Please feel free to post it here - posting bsd code in the context of a conversation is probably ok - it's when we talk about checking in the code to the Drupal.org repository that things get sticky.
Cheers,
Caleb
#4
Well this is what I used as style-rtl.css
I put up a testsite here: http://www.cicero.ws/testsites/voxforge2/
There seems to be an issue with menu alignment. Other than that it seems to do the trick. If anyone can review this more thoroughly please do!
rvk
body,div,dl,dt,dd,ul,ol,li,h1,h2,h3,h4,h5,h6,pre,form,fieldset,input,textarea,p,blockquote,th,td{
text-align: right;
direction: rtl;
}
caption,th {
text-align: right;
}
/*
For controlling alignment, layout and width of page.
*/
/*~ page alignment */
body.center #container {
text-align: right;
}
.layout .gr {
float : right;
}
/* makes good with the source order */
.a-b .b,
.a-c .c,
.b-c .c,
.layout .gr .a-b .b,
.layout .gr .a-c .c,
.layout .gr .b-c .c {
float: left;
}
/* fix nesting for above */
.a-b .gr .b,
.b-c .gr .c ,
.a-c .gr .c {
float : right;
}