lots of sql errors come up when trying to see image galleries with postgre db. after SELECT there weren't n.sticky and n.created....anyway didn't find there is a patch for it so here it is. Also an error for node.module is shown together with this image.module errors. i should report it to node module if it isnt allready fixed.

388c388
< $last = db_fetch_object(db_query_range(db_rewrite_sql('SELECT n.nid,n.sticky,n.created FROM {node} n INNER JOIN {term_node} tn ON n.nid = tn.nid WHERE tn.tid IN (%s) AND n.status = 1 ORDER BY n.sticky DESC, n.created DESC'), implode(',', $descendant_tids), 0, 1));
---
> $last = db_fetch_object(db_query_range(db_rewrite_sql('SELECT n.nid FROM {node} n INNER JOIN {term_node} tn ONn.nid = tn.nid WHERE tn.tid IN (%s) AND n.status = 1 ORDER BY n.sticky DESC, n.created DESC'), implode(',', $descendant_tids), 0, 1));
394c394
< $result = pager_query(db_rewrite_sql("SELECT n.nid, n.sticky, n.created FROM {term_node} t INNER JOIN {node} nON t.nid=n.nid WHERE n.status=1 AND n.type='image' AND t.tid=%d ORDER BY n.sticky DESC, n.created DESC"), variable_get('image_images_per_page', 6), 0, NULL, $tid);
---
> $result = pager_query(db_rewrite_sql("SELECT n.nid FROM {term_node} t INNER JOIN {node} n ON t.nid=n.nid WHEREn.status=1 AND n.type='image' AND t.tid=%d ORDER BY n.sticky DESC, n.created DESC"), variable_get('image_images_per_page', 6), 0, NULL, $tid);

CommentFileSizeAuthor
image.module.diff1.06 KBigrcic

Comments

crac’s picture

crac commented

I had to make the experience that these image-module developers dont give a sh** about patches ... we have to go through all these patches and apply them one for one.

btw I am really wondering why drupal got so much positive attention and feedback about active development, documentation and forum discussions ... thats simply a lie.

Bèr Kessels’s picture

Bèr Kessels commented

okay, now that yuur mind is clear again, rethink what you just said there, who you just insulted, and please post a big "sorry"!

-- if you dont like the choices being made for you you should start making your own! Neal Stephenson

igrcic’s picture

igrcic commented

cmon crac,
people doing this project are doing it for fun, and they are doing their best. don't forget that this isn't their job :)

Yes its true that sometimes they aren't very regular, but thats why new members (like me and you) are here, to help them. Im sure that if you have knowledge, you could ask module admin how to help him or something like that.

Im new to all this but im doing what I can, at least as module tester :), and submiting small bugs.

So be easy on them ;>

crac’s picture

crac commented

[quote]
cmon crac,
people doing this project are doing it for fun, and they are doing their best. don't forget > that this isn't their job :)
[/quote]

Yes, sure, and I am sorry if my words were a bit harsh! But on the same time I think everybody got the point I wanted to say, eventhough I used the wrong words.

I really think is a big problem for drupal, especially since the image-module is one of the most important ones and reflects the whole development attitude at best. Have a look at the projects statistics and you understand what I am talking of ...

I also wrote a patch and would do more patches but if nobody of the devs cares to introduce them in the CVS-HEAD I am not going to waste my time anymore. And it is REALLY a shame how many provided patches have been applied and how many bugs have been fixed in general, eventhough the module seems to have so many devs.

Many open source projects would be DAMN happy to have SO many people wanting to help, and the drupalers make everthing to lose them again. That is very sad!

mr700’s picture

mr700 commented

Looks like fixed for me - trying to apply the patch warns it's already applied. Shouldn't this be marked as closed?

drewish’s picture

drewish commented
Status: Needs review » Fixed

yup. it's fixed

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)