Hi I am the 'Piclens Lite'. I know that our relationship didn't start well but I go forward. I observed that you separated the gallery part into a separate module. This solution is much more cleaner like before.

Sincerely I observed that your module exists when I wanted to create my project, saw the code and the queryes and decided to post the my own. Just now checked your code and see the changes. I am ready to retreat in a way that the img users to not observe the changes. I'll think in the next days how to do that. I must deeply investigate your code first.

Also, I wanted an improvement" to copy the required js files from the piclens site to the module's folder (./js?>). I tried that but didn't succeed yet. When the piclens browser plugins isn't installed only a black window appears and no javascript errors (installed the lythbox too)

What do you think?

Comments

swentel’s picture

swentel commented

Hi Vrencian,

You were ahead of me. I was going to post a sort-a-like request to you too for a simple reason: I use img filter too nowadays and it would be handy not having to install 2 separate piclens modules in my modules directory right ? :)
As I see it, we have a 2 options I think
a) another submodule of piclens with img filter support
b) some code in your img module depending on piclens

Some patches might be needed maybe to the 'general' piclens module also, we'll see. Let me know.

I also tried copying the piclens.js to my folder and got it working, but some fiddling with the javascript file is needed. I've contacted the piclens people themselves and right now it's also safer to always point to their javascript since they are still making improvements every day on the javascript and/or flash. They will probably release a stable version one day in a package and they would notice me of this, but untill then, I'm leaving it this way.

Kris

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

I also send a feature request http://drupal.org/node/add/project-issue/drupal because I think that the Drupal core MUST support media_rss_feeds into a centralized way.

These days I'll figure out how to convert img to point to your piclens. I'll have a short vacation and a lot of work (at my primary, and payed, job) this week, but at start of next week this issue will be solved. Till then I'll update the picklens lite's project page to add it an usage warning.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented
Title: Joining forcec » 'piclens lite' to 'piclens'

... and don't worry. It isn't my intention to be this project's maintainer. :)

swentel’s picture

swentel commented

heh :)
good idea about the rss feed, I'm not sure if this will get into D6 - probably D7, but it's also my aim to get this support in.
I'm constantly thinking about splitting up the mediarss functions into a separate project, but we'll see about that later.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

Problems I observed till now with these feeds (applies also to my code)

1) See http://para.ro/node/1746/media_rss. There are impossible file names.
If the check_plain() function is not called the url's, play buttons are not show. IE7 reports better the problem (when the rss button is clicked, and it shows items with no descriptions) than firefox ((it displayed only one item and no errors reported before the fix)

2) theme_piclens_lite_html_link()
Is it possible to pass a parameter there? If nothing passed it will work like now. If you take a look to piclens_lite_media_link() you'll see that the thumbnail is passed there. When user click to the image the piclens slideshow will start on the selected node. Each node has it's own slideshow. It will be confusing a separated slideshow button on each node, I think.

3) Right now a media_rss (piclents_lite module) collects all the images from a node and all of its comments.
I couldn't figure out yet how to do that using the 'piclens' module

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

It's me again. :)

I think that a good compromise will be the follow:

1) move the existing 'piclens lite' to the img package with a new 'img_media_rss' name. Using this way users won't be confused.
2) if your module is installed the new 'img_media_rss' will detect that and use its feeds to avoid conflicting with it. It will be a gateway between 'piclens' and the 'img package'. For this I'll wait a while to let you finish eventually adjustments started.

I think that this is a reasonable solution for this 'duplication' issue.

What do you think?

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

One more think. You must know that Gallery2 svn uses piclens in its slideshow (local javascripts). When the gallery module will integrate that, both of us must avoid conflicting with it.

swentel’s picture

swentel commented

Looks good to me!
I'll get looking at the your remarks in #7 starting on thursday (we have a few days off until sunday)
I'll probably have the first adjustments thursday evening, friday morning!

swentel’s picture

swentel commented

I've done some things allready which will be available in the next built:

1) impossible file names. check_plain isn't used anymore, instead I'm using file_create_url() now.
2) theme_piclens_lite_html_link() now accepts 2 parameters
first one is another text or image then the default 'start piclens' (default to empty)
second is now the drupal_set_messsage (default to false)

Do I need todo other things to make things work ?

swentel’s picture

swentel commented
Status: Active » Closed (fixed)

closing this as img_filter is now abandoned.