drupal 6 port of notifications_autosubscribe module

All very good questions, BT.

A notification should go to anyone who is subscribed when a comment is made to a node. Don't think that has anything to do with autosubscribe.

If you create a node of type "page," you should automatically be subscribed if autosubscribe is enabled for you.

If you create a node of type "page," other users with subscriptions to content type "page" will be automatically subscribed anyway. Autosubscribe is not involved.

And it looks like posting a comment to a node subscribes you to that node.

All of this based on how I'm reading notifications_autosubscribe. Funny thing, though: I've got it enabled and the option doesn't appear on either the notifications settings page or the user account page. I'm not sure what the problem is there.

Here's a patch to port this module to drupal 6.

You'll want to make sure that all the required parameters for hook_form_alter are included. Also, that they're properly spelled.

Ok, I see what you mean.... i spelled sate instead of state =P.
Also, i had altered the function:

function notifications_autosubscribe_notifications_node_form_alter()

which I thought was an implementation of hook_form_alter or hook_form_$form-id_alter (http://drupal.org/node/144132#form-id-alter). But now I see that it isn't. Its an implementation of hook_notifications_$type_alter which is defined on the notifications.module file. So I don't think it needs to be changed.

Have you actually tested this yourself? It appears you're just guessing at what needs to be done, since your form_id is wrong and the checkbox doesn't show up where it needs to. Also, you should be using diff -up original.php new.php > filename.patch or diff -urp original_directory new_directory > filename.patch -- see http://drupal.org/patch/create

I did tested this on my computer. The form ID changed on drupal 6 for the user edit form: http://www.lullabot.com/articles/modifying-forms-5-and-6

And the checkbox does show up where it should on my machine. The fieldset changed name from notifications for drupal 5, to this version of notifications ('messaging' instead of 'notifications'). Check notifications.module file.

The diff format is what git-diff gives me. I'm not using CVS. Here's in a different format according to what you said.

Well, color me embarrassed! Sorry, my initial test went awry and the checkbox didn't show. Looks like it works, now.

I'm not figuring out where notifications_autosubscribe_notifications_node_form_alter() gets used. I haven't used the D5 version, so I don't know what to expect.

No problem. And same here, I don't know what that function is supposed to do, or where its supposed to show up if its working.

I guess its up to one of the developers of this module to take charge of this issue.

See also the patch in #310726: Updating autosubscribe code to d6 and adding subscription feature. I think the other patch adds an additional option to allow people to opt in or out of their autosubscribe default on a per node basis.

The module is already updated, this one no longer applies.

Let's merge with this other thread, and reopen if I'm missing something here, #310726: Updating autosubscribe code to d6 and adding subscription feature

Thanks