I've noticed that the 'Email address:' label still appears in teasers and full nodes even when no email address is entered.

Sorry if this is user error on my part but I couldn't find a way of removing it and the other fields only show when data is entered.

Thanks
Dan

CommentFileSizeAuthor
#7 hide_label_for_blank_emails-252378-7.patch2.35 KBAnonymous (not verified)
#1 email.diff685 bytespmarti

Comments

pmarti’s picture

pmarti commented
Status: Needs review » Active
StatusFileSize
new email.diff685 bytes

I solved this with the attached diff. Hope it helps

pmarti’s picture

pmarti commented
Status: Active » Needs review
groovypower’s picture

groovypower commented
Status: Active » Needs review

Code works great. Patch does not match up with 6.x-1.x-dev that is on the release page. Although, I do not have the latest CVS version.

mh86’s picture

mh86 commented
Status: Needs review » Fixed

hi!
I committed your patch (slightly different) and added the check for empty values to the other formatters too.
thanks for your help.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Triskelion’s picture

Triskelion commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Active

It's back in D7.

Link to contact form appears with empty email address. Clicking on link gives Page Not Found.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new hide_label_for_blank_emails-252378-7.patch2.35 KB

This should fix it.

agileware’s picture

agileware commented
Status: Needs review » Reviewed & tested by the community

Confirming #7 patch

Triskelion’s picture

Triskelion commented

Also confirm it works. When is this going to be committed?

3cwebdev’s picture

3cwebdev commented
Issue summary: View changes

Confirmed. Patch #7 works. This should be committed.

mh86’s picture

mh86 commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Patch from #7 basically looks ok, but I don't understand why we need it. I tested the Email field without the patch and I can't reproduce this problem. Not even core has checks for empty values (see text_field_formatter_view).

Would be great if someone can explain me the steps to reproduce this issue.

byrond’s picture

byrond commented
Status: Postponed (maintainer needs more info) » Active

Is it possible this issue would be fixed by #1773482: "Hide if empty" doesn't work with "Default email link" formatter in Views?