Node does not delete if form has redirect

Well the node delete option skipped the FormAPI logic completely in Drupal 5. This was fixed in Drupal 6, and now you are bound to the logic behind drupal_redirect_form(), that seems to say:

• if one of the handler sets $form_state['redirect'] = false, do not redirect
• if not, use the $form['#redirect'] if present
• if not, use the $form_state['redirect'] if present
• if not, do not redirect.

I think that logic is seriously flawed. $form_state['redirect'] should have precedence over $form['#redirect']. This seems more consistent with the wording of the FormAPI documentation (emphasis mine):

#redirect: The default goto value after form is submitted. This value should be returned by a form's submit callback function, but altering another form's #redirect value by using hook_form_alter() can be useful to change where that form redirects after it is submitted. Also see #action.

Moving to the development queue because that issue is also present there.

I had to do this redirect in hook_nodeapi (using $_REQUEST['destination'] = '<>') to get it to work for insert, update, and delete in Drupal 6.x

Subscribing to look at later. If an API change is needed, probably too late for D7, but if it can be fixed without an API change, it's still on the table.

I think I'm having trouble with a similar issue. What if a destination was checked for first before setting the new redirect path to the form array?
Doing this seems to have fixed it for me. We were having trouble with the delete button in the user/edit form.

if(!drupal_get_destination())  {
  $form['#redirect'] = 'my/new/redirect/path';
}

This should already be fixed due to #579366: How many ways are there to redirect after form submission?

Please confirm that the bug actually still exists.

Confirming that this is fixed for D7. $form_state['redirect'] is the sole place for setting the redirect (well, $_GET['destination'] takes precedence, but modules should not be setting that directly, though they can construct URLs that include a destination parameter). Default submit handlers set $form_state['redirect'], so anything that wants to change it needs to implement an additional submit handler that runs after the default one. This is potentially an argument for a new form processing stage (post_submit?), but that should be taken up in a separate issue. If someone opens that, please link to it from here.

This problem still exists for 6.16.

Here's a workaround to prevent premature redirecting if the delete button is clicked, without using an additional submit hook:

// Redirect after submission, even if user uses the delete button 
if (strpos($form['#action'], 'destination') === FALSE) {
  $form['#action'] .= '?destination=' . urlencode("your/url/here");
}

Jonah's soultion didn't do it for me... I wanted to change the destination parameter based on a condition in the _form_alter... I won't get into why but i had to. Jonah's code skips scenarios where the destination is already given.

To redfine the post-deletion destination (simulating a change in the action variable) with hook_form_alter() -- even if the destination was already passed -- on the "node_delete_confirm" form in drupal 6:

$dest = "your/cool/url";
$action = $form['#action'];
$action_parts = explode('?',$form['#action']);								
if(is_array($action_parts)){
	$action_query = $action_parts[1];
	$action_queries = explode('&',$action_query);
	if(is_array($action_queries)){
		foreach($action_queries as $idx=>$pair){
			$parts = explode("=",$pair);
			$name= $parts[0];
			$val = $parts[1];
			if($name=='destination'){
				$action_queries[$idx]='destination='.urlencode($dest);
			}
		}
		$action_query = implode("&",$action_queries);
	}
	$action_parts[1]=$action_query;
	$action = implode("?",$action_parts);
}
$form['#action']= $action;

my variables are verbose.. your code could better demonstrate brevity

This is very usefull for me..it's working fine....thanks for this post...