Hi,

In the validate case in comment_nodeapi, there is currently the following:

      if (!user_access('administer nodes')) {
        // Force default for normal users:
        $node->comment = variable_get("comment_$node->type", 2);
      }

The check for 'adminster nodes' should instead be for 'administer comments'. As seen in the 'form admin' case, the comment options are only output if the user has 'administer comments' permission:

      if (user_access('administer comments')) {
        $selected = isset($node->comment) ? $node->comment : variable_get("comment_$node->type", 2);
        $output = form_radios('', 'comment', $selected, array(t('Disabled'), t('Read only'), t('Read/write')));
        return form_group(t('User comments'), $output);
      }

So, the bug I ran into was with users who had 'administer nodes' but not 'administer comments' permission. Everything was posted with comments disabled (the validate case DIDN'T force comments to the default, but neither were they given an option to select anything). This one line patch fixes the issue.

This is present in 4.6 (where I discovered it) and in HEAD.

Cheers,
Eric

CommentFileSizeAuthor
comment.module.remove_administer_nodes.patch810 bytesejort
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ejort’s picture

Can anybody confirm or deny this issue?

ricmadeira’s picture

Yes, I can confirm it! I have had this same problem since I started using Drupal (from 4.5.2 onwards); I was just too stupid to file a bug report.

Please include this fix with the next release. Drupal 4.6.2 doesn't have it yet (I just tested it) so I have to patch it manually again.

ejort’s picture

This patch still applies, and the problem is still present. Anybody care to fix this? I'm lazy and want to minimise my diffs to the mainline drupal (even if it is just changing one word) :-)

Cheers,
Eric

Steven’s picture

Status: Needs review » Fixed

Fixed in 4.6 / HEAD.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)