5x to 6x patch
sonnen - April 29, 2008 - 21:05
| Project: | Insert Block |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
The attached patch converts Insert Block 5.x-1.x-dev into a 6x-compatible version. It also adds (very basic) function documentation and moves the filtering step into hook_filter().
Assuming the code passes muster, would you consider releasing a 6x dev version?
Thanks,
Richard
| Attachment | Size |
|---|---|
| insert_block_5x_to_6x.patch | 6.05 KB |
#1
Thanks sonnen!
Sorry to keep you hanging. I've been sick and I'm rather swamped with prepping the markitup module for release, and won't be able to review this until that is done (hopefully soon).
Perhaps someone else might step in and review the patch? Everything you need to know about applying and reviewing patches.
mlsamuelson
#2
I wasn't able to apply the patch. Was it rolled outside of the Insert Block module directory?
Anyone else have success?
mlsamuelson
#3
patched files
#4
there are some code style issues. should be fixed with the coder module
#5
fixed code style
#6
Possibly someone can roll this as a patch that includes all affected files? http://drupal.org/patch/create
#7
#8
Subscribing...
#9
Awesome. Thanks sonnen and Pasqualle.
I've committed the changes in the patch as well as adding a few other improvements to the module: because the patch converts Insert Block from a pseudo filter that uses hook_nodeapi() to handle the tag replacements, to a filter module in the classical sense, I've turned caching off for input formats that use this module by adding the 'no cache' $op case in insert_block_filter(). This can lead to a performance hit, so I've explained that folks shouldn't add the Insert Block filter to their default input formats if they're not prepared for the impact.
Additionally, for the cache setting change to be felt in upgrade situations, I've added an install file to the module with a hook_update that clears the cache...
As soon as the packaging script has it ready, this dev version of Insert Block for Drupal 6 should show up soon. After it's been used for a while and any issues are ironed out, I'll roll a 1.0 release.
Thanks!
#10
thanks. The dev snapshot is ready, but you should enable "Show snapshot release" on page http://drupal.org/node/44525/edit/releases to show it on the project page.
#11
It's there now.
#12
Automatically closed -- issue fixed for two weeks with no activity.