I think the code deleted is only needed if jQuery is < 1.2 so I’ve deleted it: D6 has jQuery 1.2.3 .

Also do we need to implement a filter method as commented earlier in code?

CommentFileSizeAuthor
jQuery_update.patch1.92 KBzeta ζ

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

We chatted in IRC about this one. I'm going to leave in the legacy code even though it's not needed in Drupal 6 any more. The consistency between the two versions makes the code easier to maintain. However, I did correct the small typo included in this patch. Committed.

zeta ζ’s picture

zeta ζ commented
Version: 6.x-1.4 » 6.x-1.6

On the subject of maintaining two versions for the sake of jQuery: what about requiring jQuery update in 5?
Would that cause more problems? Or would it help by making 5 compatible with 6 rather than the other way around?

quicksketch’s picture

quicksketch
he/him
commented

I try to make modules that work with all versions of jQuery, with or without the jQuery update module (which actually only gets you updated to jQuery 1.1, not the 1.2.3 that Drupal 6 uses). This particular case was really hair though, since most of the links on the page didn't ask to be modified :)

So unfortunately no, jQuery update won't fix the problem either, since it actually just uses a third version of jQuery:
Drupal 5: 1.0.4
Drupal 5 w/ jQuery update: 1.1.2
Drupal 6: 1.2.3

zeta ζ’s picture

zeta ζ commented

Ah OK, didnt realise it was still on 1.1.2; project page says: In order to use most current and advanced jQuery functionality – maybe that was true almost a year ago.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.