Garland: better support for site slogan

Agreed. At the very least I think it should be tagged and in the sylesheet so that we can easily adjust it without having to make any changes to the main Garland code... see this thread:

http://drupal.org/node/198500

Feature requests go against the development version.

This has been a thorn in my side for a while-- so here's a patch against the current head. I don't like to mess with other designer's designs, so this patch preserves the original look and feel (there's no change to the css) while adding id's to the site name and slogan so those wishing to style differently can do so very easily.

My only question is to the validity of having span tags inside an h1 tag. Anyone know if that will validate? (i'm working on a local test box, so I'm not sure how to check the validation).

EDIT: Here's an example of some css that this patch makes possible:

#sitename {
  display: block;
  top: 14px;
  line-height: 1.5em;
  position: relative;
  font-variant: small-caps;
}
#siteslogan {
  display: block;
  font-size: 50%;
  line-height: 3em;
  font-style: italic;
}

Your code style needs a bit of work

+  $site_title ='';

Space after =.

+    $site_fields[] = '<span id="siteslogan">'. check_plain($vars['site_slogan']).'</span>';

We have spaces on both sides of the .

Also, we do not use two words run together for IDs or classes - please hyphenate.
And, can you add the CSS to your patch?

Your code style needs a bit of work

Sorry... i'm lost without coder, lol. You'd think i'd remember the style rules after a while, but they don't seem to want to stick.

We have spaces on both sides of the .

Is this new? The one rule I do remember from coder (asking me to change dozens of lines) was that "." did not have a space when one of the items was quoted.

Also, we do not use two words run together for IDs or classes - please hyphenate.

done.

And, can you add the CSS to your patch?

Of course I can, but I purposely didn't as I didn't want to change the original appearance of the Garland theme which, as far as I know, hasn't changed since it was released. My patch was just intended to make individual styling of the site name and slogan easier-- not change the style of the distributed theme itself. I just included that bit of styling as an example for any beginners following the thread.

If you really want it in the patch itself let me know and i'll reroll.

Attached is updated patch for the other issues.

This is surely a bug. The theme allows a slogan, and concatenates it with the site title making it unusable as it stands. Since Garland is the theme that comes out of the box, it doesn't help newbies.